Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forms have better visibility on iPhone #1736

Merged
merged 3 commits into from
Mar 2, 2023
Merged

fix: forms have better visibility on iPhone #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68aa9f6
fix: forms have better visibility on iPhone
TheSlimvReal Feb 22, 2023
9c3e23c
Merge remote-tracking branch 'origin/master' into ios_fixes
TheSlimvReal Mar 2, 2023
706b99f
improved e2e test
TheSlimvReal Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions e2e/integration/MarkingChildAsDropout.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
describe("Scenario: Marking a child as dropout - E2E test", function () {
before("GIVEN I am on the details page of a specific child", function () {
// go to the url with the Child
cy.visit("child/1");
// go to a child
cy.visit("child");
cy.get("tr").eq(2).click();
// save the name of this Child to the variable
cy.get(".mat-title > .remove-margin-bottom").invoke("text").as("childName");
});
Expand All @@ -15,9 +16,7 @@ describe("Scenario: Marking a child as dropout - E2E test", function () {
cy.get('[aria-label="Open calendar"]').filter(":visible").click();
cy.get(".mat-calendar-body-active:visible").click();
// click on button with the content "Save"
cy.get(".form-buttons-wrapper:visible", { timeout: 10000 })
.contains("button", "Save")
.click();
cy.get(".form-buttons-wrapper:visible").contains("button", "Save").click();
});

it("THEN I should not see this child in the list of all children at first", function () {
Expand Down
2 changes: 2 additions & 0 deletions src/styles/resets/_mat-input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
/* display disabled form values in black for better readability as we disable forms by default */
.mat-mdc-input-element:disabled, .mat-mdc-select-disabled .mat-mdc-select-value, .mat-mdc-checkbox-disabled label {
color: mat.get-color-from-palette(mat.$light-theme-foreground-palette, text) !important;
-webkit-text-fill-color: black;
opacity: 1;
}

.mdc-text-field--filled {
Expand Down