-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Photo upload #1755
Merged
Merged
Photo upload #1755
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
3a907a9
photos can be displayed in details and child block component with cac…
TheSlimvReal a91c902
refactored queue to not send multiple similar requests at the same time
TheSlimvReal a1f591d
added edit file dialog to photo component
TheSlimvReal a0605e1
Merge branch 'master' into photo_upload
TheSlimvReal 41e4c4c
ci: update docker repository (#1792)
TheSlimvReal 75a34ac
Merge branch 'master' into photo_upload
TheSlimvReal bb0c675
Merge remote-tracking branch 'origin/master' into photo_upload
TheSlimvReal 12d0e39
Merge remote-tracking branch 'origin/photo_upload' into photo_upload
TheSlimvReal fda5556
added compression and mock implementation to photo upload
TheSlimvReal e0b06bc
implemented compressed upload for couchdb file service
TheSlimvReal b60c337
demo code for uploading children pictures
TheSlimvReal d8d46ef
Revert "ci: update docker repository (#1792)"
TheSlimvReal fa561a5
improved general support of child photos
TheSlimvReal 44c5958
only loading pictures if component is shown
TheSlimvReal b87ccef
improved usability of new photo component
TheSlimvReal dbea3b8
fixed tests
TheSlimvReal f052195
added tests for new photo component
TheSlimvReal 3b61b2f
added tests for couchdb file service
TheSlimvReal 8c5dd1a
added test for file resize utility
TheSlimvReal 27d0ce9
removed old photo functionality
TheSlimvReal b6f931e
Merge branch 'master' into photo_upload
TheSlimvReal 034fb15
undone change
TheSlimvReal 70aabde
Merge remote-tracking branch 'origin/master' into photo_upload
TheSlimvReal f0fdb50
moved compression to component level
TheSlimvReal 0975060
added sw caching for attachments
TheSlimvReal f4861ed
improved caching path
TheSlimvReal 67ae86a
improved cache strategy for more up-to-date images
TheSlimvReal 724ef72
Merge branch 'master' into photo_upload
TheSlimvReal e4dd10f
added popup for profile pictures
TheSlimvReal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
...d-dev-project/children/child-block/child-block-tooltip/child-block-tooltip.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 0 additions & 27 deletions
27
src/app/child-dev-project/children/child-photo-service/child-photo.service.spec.ts
This file was deleted.
Oops, something went wrong.
35 changes: 0 additions & 35 deletions
35
src/app/child-dev-project/children/child-photo-service/child-photo.service.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these values (size 500 max age 10 days) still make sense? This means users will have an old image for up to 10 days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand the docs correctly, after remaining 10 days offline the image will not be displayed at all anymore ("considered invalid and eviced": https://angular.io/guide/service-worker-config#maxage)? In that sense, a big maxAge makes sense for offline support.
Maybe we should change this to the mentioned "staleWhileRevalidate" strategy though? In combination with our in-memory cache that could be a better fit?