Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary import to reduce scss file size #1774

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

TheSlimvReal
Copy link
Collaborator

Currently, the master build shows warnings that some scss files exceed the size budget by around 100kb (budget is 6kb). This is because the app theme has been imported in the _colors.scss file where it is not even used.

Visible/Frontend Changes

--

Architectural/Backend Changes

  • various scss files are smaller

@github-actions
Copy link

Deployed to https://pr-1774.aam-digital.net/

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TheSlimvReal TheSlimvReal merged commit e13c8fa into master Mar 16, 2023
@TheSlimvReal TheSlimvReal deleted the scss_fix branch March 16, 2023 15:30
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants