Common popup buttons #1794
Common popup buttons #1794
Conversation
|
Deployed to https://pr-1794.aam-digital.net/ |
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
TheSlimvReal
force-pushed
the
note_redesign
branch
from
39f8593 to
da0d4ac
Compare
TheSlimvReal
force-pushed
the
common_popup_buttons
branch
from
3ec50fd to
d897f8b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
|
||
| constructor( | ||
| private entityFormService: EntityFormService, | ||
| private dialog: MatDialogRef<any>, |
There was a problem hiding this comment.
is this legit to inject here, as the component is only indirectly created through MatDialog? ... Seems to work though, I guess.
There was a problem hiding this comment.
Yeah I was thinking the same but I guess the injection is also valid all children of the component. I believe this is how the component scoped injection works.
Based on #1752, so review and merge this first.
Cleanup and generalisation of the
Save,Cancel,Go to detailsandDeletebuttons in the various popups (NoteDetails,TodoDetails,RowDetails).Visible/Frontend Changes
Architectural/Backend Changes
--