Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report performance #1819

Merged
merged 15 commits into from
Apr 17, 2023
Merged

Report performance #1819

merged 15 commits into from
Apr 17, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Apr 12, 2023 •
edited
Loading

Improving performance of reports

Visible/Frontend Changes

  • Added paginator to export table

Architectural/Backend Changes

  • Removed/refactored asynchrony from query service and using services

@TheSlimvReal TheSlimvReal changed the title Report perf Report performance Apr 12, 2023
@github-actions
Copy link
Contributor

Deployed to https://pr-1819.aam-digital.net/

TheSlimvReal
TheSlimvReal commented Apr 12, 2023
View reviewed changes
src/app/core/config/config-fix.ts Outdated
}, {
"title": "Participant Details Report (pseudonymized)",
"mode": "exporting",
"aggregationDefinitions": [
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for testing reasons, will be removed before merge

sleidig
sleidig approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks smart and seems to work well 👍

@sleidig
Copy link
Member

sleidig commented Apr 12, 2023

Definitely learned something new about JavaScript from this 😄

a bit further reading on this: "adding an async modifier to the method can almost double [~81%] the time it takes to execute"
https://madelinemiller.dev/blog/javascript-promise-overhead/

two possible solutions to mitigate:

  • perform data fetching or other asynchronous operations closer to the application's root and pass the resulting data down
  • only use the async keyword for the inner-most method and in the next higher level work with the promise

@TheSlimvReal TheSlimvReal marked this pull request as ready for review April 13, 2023 07:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 95d8108 into master Apr 17, 2023
@TheSlimvReal TheSlimvReal deleted the report_perf branch April 17, 2023 04:56
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.1-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.20.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @sleidig @aam-digital-ci