Improved app initialisation #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-1890.aam-digital.net/ |
|
Kudos, SonarCloud Quality Gate passed!
|
sleidig
approved these changes
Jun 8, 2023
|
🎉 This PR is included in version 3.21.1-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.21.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment we have the problem that properties defined in the config are not yet available in the demo data generators.
This is because the config is saved last. If the config is saved first we have another problem where the app is loaded but on the initial screen some views might be empty because the app builds once the config is ready but the demo data is only created and saved afterwards.
The new solution is to save the config first but postpone the creation of the app.
This is done by moving the initialisation logic from the app component to the
APP_INITIALIZERprovider.This way all the initialisation is done and only afterwards the
AppComponentgets build.