Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): support "required" indicator for custom form-controls #2068

Merged
merged 6 commits into from
Nov 15, 2023
Merged

fix(core): support "required" indicator for custom form-controls #2068

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a1e9b0
fix(core): support "required" indicator for custom form-controls
sleidig Nov 8, 2023
e40cae5
fix test
sleidig Nov 8, 2023
8aa3d21
Update src/app/core/common-components/basic-autocomplete/custom-form-…
sleidig Nov 10, 2023
d189c56
fix lint
sleidig Nov 10, 2023
20db1eb
simplify code
sleidig Nov 10, 2023
d9f33ea
Merge branch 'master' into dropdown-required
sleidig Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/app/core/common-components/basic-autocomplete/custom-form-control.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
FormGroupDirective,
NgControl,
NgForm,
Validators,
} from "@angular/forms";
import { MatFormFieldControl } from "@angular/material/form-field";
import {
Expand All @@ -28,7 +29,16 @@ export abstract class CustomFormControlDirective<T>
// eslint-disable-next-line @angular-eslint/no-input-rename
@Input("aria-describedby") userAriaDescribedBy: string;
@Input() placeholder: string;
@Input() required = false;

@Input()
get required() {
return this._required;
}
set required(req: boolean) {
this._required = coerceBooleanProperty(req);
this.stateChanges.next();
}
private _required = false;

abstract inputElement: { _elementRef: ElementRef<HTMLElement> };
stateChanges = new Subject<void>();
Expand Down Expand Up @@ -139,5 +149,15 @@ export abstract class CustomFormControlDirective<T>
this.errorState = newState;
this.stateChanges.next();
}

if (control) {
if (control.hasValidator(Validators.required)) {
this.required = true;
this.stateChanges.next();
} else if (this.required) {
this.required = false;
this.stateChanges.next();
}
sleidig marked this conversation as resolved.
Show resolved Hide resolved
}
}
}