Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): change EntityConfig to flattened structure with EntitySchemaField including .id #2102

Merged
merged 11 commits into from
Nov 30, 2023

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Nov 24, 2023

To ease the development of the setup wizard (PR #2049 ) this refactors config structure including an on-the-fly migration.


⚠️ mark as codo

@sleidig sleidig requested a review from TheSlimvReal November 24, 2023 17:40
Copy link

Deployed to https://pr-2102.aam-digital.net/

src/app/core/config/config.service.ts Outdated Show resolved Hide resolved
src/app/core/entity/schema/entity-schema-field.ts Outdated Show resolved Hide resolved
src/app/core/entity/entity-config.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks very clean. I really like the new format.

src/app/core/config/config.service.ts Show resolved Hide resolved
@sleidig sleidig merged commit 9eb2b4f into master Nov 30, 2023
7 of 8 checks passed
@sleidig sleidig deleted the entity-config branch November 30, 2023 16:46
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.27.2-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Dec 5, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.27.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants