Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove short ID #2148

Merged
merged 25 commits into from
Feb 1, 2024
Merged
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
8a737ea
reduced usage of short id in code
TheSlimvReal Jan 2, 2024
e352f99
fixed some bugs
TheSlimvReal Jan 2, 2024
c2e8a9d
fixed view issues
TheSlimvReal Jan 2, 2024
212f68d
fixed tests
TheSlimvReal Jan 2, 2024
fed3556
removed furhter usages of short id
TheSlimvReal Jan 2, 2024
4197c8e
removed furhter usages of short id in tests
TheSlimvReal Jan 2, 2024
c518c43
flipped function attribute meaning of `getId()`
TheSlimvReal Jan 2, 2024
86c4db0
Merge branch 'master' into remove_short_id
TheSlimvReal Jan 2, 2024
f4757c2
small cleanups
TheSlimvReal Jan 3, 2024
44e5df0
removed trivial function
TheSlimvReal Jan 6, 2024
f972732
entity details support full ids
TheSlimvReal Jan 6, 2024
e3d1418
Merge branch 'master' into remove_short_id
TheSlimvReal Jan 6, 2024
32efef0
Merge branch 'master' into remove_short_id
TheSlimvReal Jan 15, 2024
3ff33f1
added datatype config for educational material
TheSlimvReal Jan 16, 2024
ab6021a
fixed showInactive logic in ChildSchoolOverview
TheSlimvReal Jan 16, 2024
40c67a6
removed some todos
TheSlimvReal Jan 16, 2024
6e1b239
todo completion displays entity `toString`
TheSlimvReal Jan 16, 2024
a08b5b5
report title is optional
TheSlimvReal Jan 16, 2024
294b3d3
removed addPrefix function from query service
TheSlimvReal Jan 16, 2024
4701c92
Merge branch 'master' into remove_short_id
sleidig Jan 22, 2024
7e8848d
Merge branch 'master' into remove_short_id
TheSlimvReal Jan 23, 2024
250bf8f
fixed completedBy issue
TheSlimvReal Jan 23, 2024
4c2f3c9
removed duplicate test
TheSlimvReal Jan 23, 2024
6ff37db
review cleanups
TheSlimvReal Jan 23, 2024
ed70ebb
Merge branch 'master' into remove_short_id
TheSlimvReal Feb 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed some todos
  • Loading branch information
TheSlimvReal committed Jan 16, 2024
commit 40c67a6517eaa5c2675bed881e8f9dc4b89d05e2
Original file line number Diff line number Diff line change
@@ -38,7 +38,6 @@ export class ConfigurableEnumService {
if (!this.enums) {
return;
}
// TODO or de we rather want to pass full IDs around here as well?
const entityId = Entity.createPrefixedId(ConfigurableEnum.ENTITY_TYPE, id);
if (
!this.enums.has(entityId) &&
Original file line number Diff line number Diff line change
@@ -89,7 +89,6 @@ export class ConfigureEnumPopupComponent {
private async getUsages(value: ConfigurableEnumValue) {
const enumMap: { [key in string]: string[] } = {};
for (const entity of this.entities.values()) {
// TODO should this be migrated?
const schemaFields = [...entity.schema.entries()]
.filter(
([_, schema]) =>
2 changes: 1 addition & 1 deletion src/app/core/entity/schema/entity-schema-field.ts
Original file line number Diff line number Diff line change
@@ -46,7 +46,7 @@ export interface EntitySchemaField {
*
* @todo not implemented yet
*/
generateIndex?: boolean; // TODO: implement index support in EntitySchema
generateIndex?: boolean;

/**
* If set to `true`, the entity can be found in the global search by entering this value
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ export class TodosRelatedToEntityComponent implements OnInit {
{ id: "completed", hideFromForm: true },
];

/** the property name of the Todo that contains the ids referencing related entities */
/** the property name of the entity that contains the ids referencing related entities */
private referenceProperty: keyof Todo & string = "relatedEntities";

showInactive: boolean;