-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use PouchDB Browser #217
Use PouchDB Browser #217
Conversation
PouchDB is able to run both in NodeJS as well as in a Browser. In a browser, IndexedDB will be used, for NodeJS, however, Leveldown is the backend, which installs a binary. There are officially supported versions of PouchDB that don't come with this dependency (that fails to install on some modern versions of node due to prebuilds not being available). We should use these stripped versions to have less dependencies in our project. See https://pouchdb.com/custom.html for more information.
Code Climate has analyzed commit ede2134 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 71.4% (0.0% change). View more on Code Climate. |
Be sure to disable The error at the Notes tab is also present in the current master, and comes from issues with the foreign keys in the dev database: Update: #218 |
@Lorsbyjm, did you perform any actions to get this issue? Is this on a fresh local DB (in an Incognito Tab)? I could not reproduce this issue on both my computers on both fresh and already-present local databases. Maybe this is related to the database-indices you added recently? These indices would be created by map-reduce-functions and might have issues with unexpected old values in the DB (i.e. text where only numbers are expected). Maybe they were added to your local PouchDB during development/testing, but are maybe not present in this branch? |
Ok guys, should be good. While starting in icognito mode it has the same error like the master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned before, all good.
PouchDB is able to run both in NodeJS as well as in a Browser. In a browser, IndexedDB will be used, for NodeJS, however, Leveldown is the backend, which needs a binary. Per default, PouchDB will install support for both scenarios, with the binary failing to install on some versions of node due to prebuilds not being available (i.e. 9, 11).
There are officially supported versions of PouchDB ("presets") that don't come with this dependency. We should use these stripped versions to have less dependencies in our project, allowing a faster and more stable npm install.
See https://pouchdb.com/custom.html for more information.