fix: correctly opening creating new page when clicking "+" button

src/app/core/common-components/entities-table/entities-table.component.spec.ts

@@ -18,6 +18,7 @@ import { of } from "rxjs";
 import { CoreTestingModule } from "../../../utils/core-testing.module";
 import { FormDialogService } from "../../form-dialog/form-dialog.service";
 import { DateDatatype } from "../../basic-datatypes/date/date.datatype";
+import { Router } from "@angular/router";
 
 describe("EntitiesTableComponent", () => {
   let component: EntitiesTableComponent<Entity>;
@@ -273,4 +274,19 @@ describe("EntitiesTableComponent", () => {
       component._columns.find((c) => c.id === "children").noSorting,
     ).toBeTrue();
   });
+
+  it("should navigate to '/new' route on newly created entities", () => {
+    const navigateSpy = spyOn(TestBed.inject(Router), "navigate");
+    component.clickMode = "navigate";
+
+    const child = new Child();
+    expect(child.isNew).toBeTrue();
+    component.showEntity(child);
+    expect(navigateSpy).toHaveBeenCalledWith(["/child", "new"]);
+
+    child._rev = "1-existing";
+    expect(child.isNew).toBeFalse();
+    component.showEntity(child);
+    expect(navigateSpy).toHaveBeenCalledWith(["/child", child.getId(true)]);
+  });
 });

src/app/core/common-components/entities-table/entities-table.component.ts

@@ -278,7 +278,7 @@ export class EntitiesTableComponent<T extends Entity> implements AfterViewInit {
       case "navigate":
         this.router.navigate([
           entity.getConstructor().route,
-          entity.getId(true),
+          entity.isNew ? "new" : entity.getId(true),
         ]);
         break;
     }

src/app/core/entity-details/related-entities/related-entities.component.html

@@ -6,4 +6,5 @@
   [columnsToDisplay]="columnsToDisplay"
   [newRecordFactory]="createNewRecordFactory()"
   [showInactive]="showInactive"
+  [clickMode]="clickMode"
 ></app-entities-table>

src/app/core/entity-details/related-entities/related-entities.component.ts

@@ -61,6 +61,8 @@ export class RelatedEntitiesComponent<E extends Entity> implements OnInit {
 
   @Input() showInactive: boolean;
 
+  @Input() clickMode: "popup" | "navigate" = "popup";
+
   data: E[];
   private isArray = false;
   protected entityCtr: EntityConstructor<E>;

src/app/core/entity-details/related-time-period-entities/related-time-period-entities.component.ts

@@ -45,7 +45,6 @@ export class RelatedTimePeriodEntitiesComponent<E extends TimePeriod>
 
   @Input() single = true;
   @Input() showInactive = false;
-  @Input() clickMode: "popup" | "navigate" = "popup";
 
   @Input() set columns(value: FormFieldConfig[]) {
     this._columns = [...value, isActiveIndicator];