Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Step-wise Setup Wizard #2280

Merged
merged 81 commits into from
Apr 25, 2024
Merged

Step-wise Setup Wizard #2280

merged 81 commits into from
Apr 25, 2024

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Mar 7, 2024 •
edited
Loading

closes: #2049

⚠️ mark as @codo-mentoring

sleidig added 30 commits December 21, 2023 20:59
@sleidig
first step (mostly working) refactoring of entities-table component
1dd2703
@sleidig
Merge branch 'master' into admin-list
2716644
@sleidig
move code locations
a16d52b
@sleidig
extract inline-edit
2785f19
@sleidig
extract create button
fb2186d
@sleidig
fix some tests
b8d152a
@sleidig
fix remaining tests & bugs
b827d72
@sleidig
Update src/app/core/common-components/entities-table/list-paginator/l…
3737477 
…ist-paginator.component.scss
@sleidig
Update src/app/core/common-components/entities-table/entity-inline-ed…
e4b37cb 
…it-actions/entity-inline-edit-actions.component.ts
@sleidig
Merge branch 'master' into admin-list
a5b212a
@sleidig
remove unneeded code
2d139ba
@sleidig
Merge remote-tracking branch 'origin/admin-list' into admin-list
542aca6
@sleidig
add fields-menu and positioning
cb31631
@sleidig
Merge branch 'master' into admin-list
f033ddd
@sleidig
remove unnecessary @UntilDestroy from child classes
30d8444
@sleidig
use base class onInit for ChildSchoolOverview
d1c7a52
@sleidig
remove ngIf for table action columns
5162288
@sleidig
clarify comment for duplicate column config removal
421c983
@sleidig
remove unnecessary updateSubscription variables
d1c0cb4
@sleidig
simplify updateColumnsToDisplayForScreenSize
73ccb14
@sleidig
use super.ngOnInit
bc1e2bb
@sleidig
Merge branch 'master' into admin-list
07e46a9
@sleidig
fix test
d08bb44
@sleidig
fix ed mat
9664842
@sleidig
fix inline editing UI + triggering popup
dacfe71
@sleidig
fix inline editing unsavedChanges
c2e4d6e
@sleidig
correctly display relevant fields in popup
6c6f6e9
@sleidig
fix sort issue when setting programmatically from config
1213ff6
@sleidig
use inheritance to identify date types
39a6c6b
@sleidig
fix tests
36a687e
@sleidig sleidig changed the title Setup steps Step-wise Setup Wizard Mar 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Deployed to https://pr-2280.aam-digital.net/

sleidig added 10 commits March 7, 2024 18:09
@sleidig
layout tuning
b7dc4e4
@sleidig
translations and styling
881a144
@sleidig
Merge branch 'admin-list2' into setup-steps
19691c9
@sleidig
Merge branch 'master' into setup-steps
fbb7560 
# Conflicts:
#	src/app/core/admin/admin-entity-list/admin-entity-list.component.spec.ts
#	src/app/core/admin/admin.routing.ts
#	src/assets/locale/messages.de.xlf
#	src/assets/locale/messages.fr.xlf
#	src/assets/locale/messages.it.xlf
#	src/assets/locale/messages.xlf
@sleidig
Merge branch 'master' into setup-steps
2975396
@sleidig
Merge branch 'master' into setup-steps
6066ffc
@sleidig
small ui adaptions
a62aec4
@sleidig
make configurable and formatted with markdown
19019bd
@sleidig
save progress and dismissal of setup wizard
34274da
@sleidig
translations
d784b45
@sleidig sleidig marked this pull request as ready for review April 19, 2024 10:58
@sleidig sleidig requested a review from tomwwinter April 19, 2024 11:03
tomwwinter
tomwwinter approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@tomwwinter tomwwinter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe write some more tests to reach the threshold?

@sleidig sleidig merged commit c8b7bd6 into master Apr 25, 2024
7 checks passed
@sleidig sleidig deleted the setup-steps branch April 25, 2024 09:51
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0-master.14 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Apr 25, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomwwinter tomwwinter tomwwinter approved these changes

Assignees
No one assigned
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Wizard: Step-wise onboarding / setup process
3 participants
@sleidig @aam-digital-ci @tomwwinter