Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): reset anonymized fields immediately #2331

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Apr 2, 2024

fixes #2285

Visible/Frontend Changes

  • when clicking "anonymize" for an entity, the fields that are removed are immediately shown as empty in the form

Architectural/Backend Changes

  • store "anonymized" removed properties as null to mark them explicitly as reset
  • retain null values during entity-schema transformations, to allow such explicitly reset values
  • prevent normal forms to save all empty fields as 'null'

@sleidig sleidig requested a review from tomwwinter April 2, 2024 17:31
Copy link

github-actions bot commented Apr 2, 2024

Deployed to https://pr-2331.aam-digital.net/

@sleidig sleidig force-pushed the fix/anonymization-change-detection branch from 1ec255e to 3014ad7 Compare April 3, 2024 06:52
@sleidig sleidig force-pushed the fix/anonymization-change-detection branch from 3014ad7 to 8a6396b Compare April 3, 2024 07:25
Copy link
Contributor

@tomwwinter tomwwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomwwinter tomwwinter merged commit ae299b4 into master Apr 8, 2024
7 checks passed
@tomwwinter tomwwinter deleted the fix/anonymization-change-detection branch April 8, 2024 08:54
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Apr 8, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

anonymized fields that get deleted are not updated until reload
3 participants