Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Configuring PII /Anyonymization #2335

Merged
merged 47 commits into from
Apr 24, 2024

Conversation

Abhinegi2
Copy link
Contributor

@Abhinegi2 Abhinegi2 commented Apr 10, 2024

closes:#2120

Visible/Frontend Changes

  • Added a New tab to configure PII settings of Entity type.
  • Added checkbox to change the Anonymize settings of Entity.
  • Added Mat-Table to show the fields related to anonymized settings.
  • While switching between tabs PII changes will not lost until.

@Abhinegi2 Abhinegi2 self-assigned this Apr 10, 2024
Copy link

Deployed to https://pr-2335.aam-digital.net/

@Abhinegi2 Abhinegi2 changed the base branch from master to feature/enable-multiselect-for-tostringattribute April 10, 2024 12:01
@Abhinegi2 Abhinegi2 marked this pull request as ready for review April 15, 2024 09:49
@Abhinegi2 Abhinegi2 requested a review from sleidig April 15, 2024 09:50
@Abhinegi2
Copy link
Contributor Author

@Abhinegi2 , experimenting with the UI I have decided on some adjustment and still see some polishing to do:

  • removed pagination, to give user a full, seamless overview of all fields
  • limit the height, so that the scroll is within the "Configure PII" tab, not for the whole screen if many fields are listed
  • fields need to display the field.label in the table, not the key/id

Hi @sleidig I have implemented the following feedback can you please confirm whether UI is looking good or not -

  1. Added height limit on PII fields.
  2. Display the field name instead of the field key.

@sleidig
Copy link
Member

sleidig commented Apr 18, 2024

@Abhinegi2 , the scroll is still not working very well:
image

I would like to

  • always have only on scroll bar (only scroll within the tabs' contents, i.e. the inner scrollbar)
  • use the full height of the (remaining) screen before having to scroll (i.e. avoid the white space at bottom currently)

@sleidig
Copy link
Member

sleidig commented Apr 23, 2024

@Abhinegi2 , the validator PR has been merged. Can you please replace the simple input field in the AdminEntityField with the new dropdown component here also

@Abhinegi2
Copy link
Contributor Author

@Abhinegi2 , the validator PR has been merged. Can you please replace the simple input field in the AdminEntityField with the new dropdown component here also

sure working on this part

@sleidig sleidig merged commit b275ab2 into master Apr 24, 2024
5 of 7 checks passed
@sleidig sleidig deleted the feature/Configuring-PII/Anyonymization branch April 24, 2024 17:47
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0-master.11 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Apr 24, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants