Feature/public config should suport dynamic values #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2635.aam-digital.net/ |
|
let me resolve the conflicts. |
tomwwinter
reviewed
Oct 28, 2024
tomwwinter
reviewed
Oct 28, 2024
src/app/features/public-form/demo-public-form-generator.service.ts
Outdated
Show resolved
Hide resolved
sleidig
reviewed
Nov 4, 2024
@tomwwinter I have updated the EntityFormService now the default value is working fine. You can test this further. |
tomwwinter
requested changes
Nov 12, 2024
sleidig
reviewed
Nov 20, 2024
src/app/core/common-components/entity-form/entity-form.service.ts
Outdated
Show resolved
Hide resolved
sleidig
added a commit
that referenced
this pull request
Nov 20, 2024
while still including the angular form field for default values etc. see #2635
|
This is ready to merge as soon as #2668 is available |
sleidig
reviewed
Nov 20, 2024
sleidig
added a commit
that referenced
this pull request
Nov 21, 2024
while still including the angular form field for default values etc. see #2635
sleidig
added a commit
that referenced
this pull request
Nov 21, 2024
while still including the angular form field for default values etc. see #2635
sleidig
deleted the
feature/public-config-should-suport-dynamic-values
branch
|
🎉 This PR is included in version 3.43.0-master.8 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.43.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2401
Visible/Frontend Changes