Url datatype #2646
Open
Url datatype #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleidig
requested changes
Oct 31, 2024
There was a problem hiding this comment.
It seems like you didn't test this in the app yet 😉 It didn't work for me because we forgot to register the components (see my commit now).
The component still has some issues. Test it while keeping the Developer Console open and see various errors. I think it is not "allowed" to mark a <a with matInput, this only works for <input as far as I know.
src/app/core/basic-datatypes/string/display-url/display-url.component.ts
Outdated
Show resolved
Hide resolved
…t.html Co-authored-by: Sebastian <sebastian@aam-digital.com>
…mponent.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2460