refactor(logging): update to latest sentry sdk and use LoggerService #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleidig
changed the title
sleidig
force-pushed
the
improved-remote-logging
branch
from
2e46b9d
to
8f669ac
Compare
sleidig
changed the title
liwde
reviewed
Dec 4, 2019
| .config('https://bd6aba79ca514d35bb06a4b4e0c2a21e@sentry.io/1242399') | ||
| .install(); | ||
| Sentry.init({ | ||
| dsn: 'https://bd6aba79ca514d35bb06a4b4e0c2a21e@sentry.io/1242399', |
There was a problem hiding this comment.
Should these values be moved to appconfig?
There was a problem hiding this comment.
This makes it somehow very hard to catch errors during startup, as the appconfig is injected somewhere in the process. Storing the messages in some kind of queue until we initialized the client would be a bigger change... Maybe we should set up a different issue tracking this. What do you think?
There was a problem hiding this comment.
Yeah, this would actually belong into the config.json ... but when I tried now I was indeed failing to get the config ready loaded while still having things cleanly separated.
I opened a separate issue for this now (#385) so that the cleaned up logging can be release already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved (remote) logging