Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace datepickers with material datepickers #395

Merged
merged 5 commits into from
Jan 21, 2020
Merged

Conversation

KatSB
Copy link
Contributor

@KatSB KatSB commented Jan 14, 2020

see issue: #370

Visible/Frontend Changes

  • Replace datepicker in NoteDetailsComponent
  • Replace datepicker in SubrecordEntityComponent
  • Replace datepicker in Health section of ChildDetails
  • Replace datepicker in Dropout of ChildDetails
  • Replace datepicker in Attendance Register filters
  • Replace datepicker in Add Daily Attendance
    (Child School Relations (popup when editing lines of the Education section in ChildDetails) is not modified because of problems with dates as strings)

@sleidig
Copy link
Member

sleidig commented Jan 16, 2020

sorry for the merge conflicts. This is because we moved all the folders around a little bit (#394). Maybe the easiest way to fix it is to take the files you changed and copy them to their new location of the master branch (replacing the files that are there and don't include your changes yet). If you get stuck, let me know.

KatSB added 3 commits January 19, 2020 17:26
# Conflicts:
#	src/app/child-dev-project/attendance/add-day-attendance/add-day-attendance.component.spec.ts
#	src/app/child-dev-project/attendance/attendance-manager/attendance-manager.component.spec.ts
#	src/app/child-dev-project/health-checkup/health-checkup-component/health-checkup.component.spec.ts
#	src/app/child-dev-project/notes/note-details/note-details.component.spec.ts
#	src/app/core/ui-helper/entity-subrecord/entity-subrecord.component.spec.ts
#	src/app/core/ui-helper/ui-helper.module.ts
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I like the new design

@TheSlimvReal TheSlimvReal merged commit 0441cb6 into master Jan 21, 2020
@TheSlimvReal TheSlimvReal deleted the mat-datepicker branch January 21, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants