-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimized searchbar: only words, removed bug in parse rows #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
and thereby also ensure that search results' photo is loaded
aea0e66
to
f1b2072
Compare
I noticed here that the previous merge in the master of the ChildPhotoService had broken the photos in the search result. After some forth and back I ended up with a larger change (moving the loading of the photos to a new EntitySchemaDatatype). |
@sleidig what do you want to achive. Now no pictures are shown. |
…rough EntitySchema this fixes a bug displaying broken child photos
Oh, you are absolutely right. there was another bug that converted an undefined photoFile name wrongly and broke images if you have not set up the Nextcloud integration. This should be fixed now. I also shared a test account for nextcloud in our slack in case you want to test with that as well. |
I do not have enough experience to review the code, but it looks like it is working. Furthermore the loading takes even more time if for every search reslut the image is loaded from the nextcloud. We might think about limiting the search result to an special threshold and not show it if there are more. But to ask the user for more input. |
limiting it (maybe also just start after input of at least 3 characters) might be a good idea. The photo load should work asynchronously however - first return the path to the default image (or one that has been uploaded by the server admin) and only later replacing that if a photo is returned from the cloud. |
see issue: #366
Visible/Frontend Changes
searchbar dissapers when searchfield is empty
searching does not take that long
please check the regex expression, it should allow only strings with at least one characters or number
remeber:
Search depends on pouchdb indices so this can only be debugged when setting useTemporaryDatabase to false in the config.json