Data reports #719

TheSlimvReal · 2021-03-17T15:47:23Z

Visible/Frontend Changes

Add a component for admins to download reports for a specified time

Architectural/Backend Changes

Create new reporting module and aggregation service
Count children based on their attributes
Count events in a timespan based on attributes of linked activities and schools
Count participants of events in a timespan based on attributes of linked activities and schools
Create config structure for report queries
Combine query results in a excel
Add groupBy option which disaggregates objects by the passed attribute

# Conflicts: # src/app/core/admin/admin/admin.component.ts # src/app/core/admin/services/backup.service.ts

github-actions · 2021-03-17T15:48:10Z

Deployed to https://test-deployment-pr-719.herokuapp.com/

src/app/child-dev-project/reporting/aggregation.service.spec.ts

src/app/child-dev-project/reporting/aggregation.service.ts

TheSlimvReal · 2021-05-11T07:36:55Z

The new big changes:

Loading data only from the given from date till today
Directly passing the values of the groupBy`s down, so each row has a full list of values of the group it is in
Moved module to the features folder
isActive is now also a getter on the ChildSchoolRelation entity (I did not yet see a good reason to make the isActive a inherited property of Entity class).

src/app/features/reporting/query.service.ts

src/app/features/reporting/reporting.service.ts

# Conflicts: # src/app/features/reporting/reporting/reporting.component.ts

ghost · 2021-05-12T12:08:26Z

DeepCode's analysis on #14eaee found:

ℹ️ 1 minor issue. 👇

Top issues

Description	Example fixes
Use an array literal instead of the Array constructor. Occurrences: reporting.service.ts:144	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

sonarqubecloud · 2021-05-12T12:10:31Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
2.3% Duplication

aam-digital-ci · 2021-05-12T12:27:40Z

🎉 This PR is included in version 2.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

TheSlimvReal added 4 commits March 15, 2021 16:28

removing _rev fields when importing backups

eb4ee76

created service to calculate aggregations

50ac866

changed query function to return single result

94f9d90

Merge remote-tracking branch 'origin/master' into data_reports

49b2d14

# Conflicts: # src/app/core/admin/admin/admin.component.ts # src/app/core/admin/services/backup.service.ts

Not queries can be applied everywhere

afea540

sleidig reviewed Mar 18, 2021

View reviewed changes

src/app/child-dev-project/reporting/aggregation.service.spec.ts Outdated Show resolved Hide resolved

sleidig reviewed Mar 18, 2021

View reviewed changes

src/app/child-dev-project/reporting/aggregation.service.spec.ts Outdated Show resolved Hide resolved

sleidig reviewed Mar 18, 2021

View reviewed changes

src/app/child-dev-project/reporting/aggregation.service.ts Outdated Show resolved Hide resolved

sleidig reviewed Mar 18, 2021

View reviewed changes

src/app/child-dev-project/reporting/aggregation.service.ts Outdated Show resolved Hide resolved

TheSlimvReal added 20 commits March 18, 2021 12:51

working on the attendance queries

4473f4f

Added a service which uses the json-query library

1e8ab6a

fixed aggregation service

b4054b5

removed aggregation service

e60580b

Added description

e997cdb

fixed prettier

6eefe29

Merge remote-tracking branch 'origin/master' into data_reports

b97e342

fixed tests

09b6700

cleaned up tests

5317a9d

added tests for querying ChildSchoolRelations

db53baa

added option to run query on custom data and added count function

29b1080

Added service which creates the reports as a key value array

8a691c7

Service adds a from and to date to each query

d83feb5

Refactored reporting service to not load reports from the config

40027f6

fixed reporting service to load data first

c2a2a99

added component which displays reports

47a7b35

added stepper component

73c5bbb

component uses stepper to guide user

616ecec

Added export button

de45560

Changed csv export to not automatically add _id and _rev field

fcd8d3d

added documentation and transformed isActive into a getter

711d569

TheSlimvReal marked this pull request as ready for review May 11, 2021 07:32

fixed lint error

1fde853