Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed getFilter function to descern between '3_d' and '3_m' #216

Merged
merged 3 commits into from
Oct 31, 2020

Conversation

fluentinstroll
Copy link
Contributor

addresses issue #215

changed from

if (tester.startsWith('3'))
        tester = '3_days';

to

if (tester.startsWith('3_d'))
        tester = '3_days';
    else if (tester.startsWith('3_m'))
        tester = '3_months';

in order to properly discern between months and days as mentioned above.

@fluentinstroll
Copy link
Contributor Author

I believe this failed because the tests expect the input of "3" to spit out "3_days" which will not happen with my changes - I didn't want to change the tests because they weren't within the purview of the issue I was addressing. However, I can change them with permission.

@tehhowch
Copy link
Collaborator

You should update the tests as well 👍

Copy link
Collaborator

@tehhowch tehhowch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tehhowch tehhowch merged commit e44d4d7 into AardWolf:dev Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants