Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust backend for fedibook #17

Merged
merged 7 commits into from
Nov 30, 2017

Conversation

pwoolcoc
Copy link

This is a rather large PR, I've included a small write-up/tutorial at https://github.com/pwoolcoc/fedibook/blob/add-rocket-and-diesel/src/README.md to hopefully aid in code review

Paul Woolcock added 7 commits November 30, 2017 10:51
Most of the meat of the app is contained in a `lib`-style crate, with
the actual server being a `bin`-style crate that lives in
`src/bin/main.rs`. This is done so that we can easily add binaries that
share models, database schemas, etc, down the line.
Copy link
Contributor

@KD0BPV KD0BPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great to me, and I'm approving it. If Peter concurs, it'll get merged. I'll get started on adapting my configuration module to this.

Can you send me a list of what values your code will need from the config files? I'm parsing them out as best I can, but would like to be sure I don't miss any of them.

@BanjoFox
Copy link
Collaborator

....welp.... I suddenly feel like I'm way behind again... lol..

@BanjoFox BanjoFox merged commit d3503a0 into Aardwolf-Social:master Nov 30, 2017
@jfmcbrayer
Copy link
Contributor

Wow, this is great. I really need to get to work on the models for ActivityStreams2 objects.

@jfmcbrayer
Copy link
Contributor

Pardon the rust newbie question, but does this take a beta or unstable version of rustc to compile? While building the required crates (log v0.3.8), I get:

error[E0554]: #![feature] may not be used on the stable release channel

@pwoolcoc
Copy link
Author

pwoolcoc commented Nov 30, 2017

@jfmcbrayer yes, I definitely should have mentioned it. Currently it requires nightly. Until rocket runs on stable, we won't be able to use stable or beta: rwf2/Rocket#19

@jfmcbrayer
Copy link
Contributor

Ok, will install nightly here.

@BanjoFox
Copy link
Collaborator

BanjoFox commented Dec 1, 2017

@jfmcbrayer - you should also be able to have stable and nightly branches, and switch between them accordingly. I -think- it goes something like

rustup install nightly
rustup default [stable|nightly]

@pwoolcoc
Copy link
Author

pwoolcoc commented Dec 1, 2017

@BanjoFox that is correct, but we will not be able to use stable or beta for this project until Rocket.rs can compile on them. (The list of features that need to be stabilized for that to happen is in the issue I linked to above)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants