Skip to content

Commit

Permalink
fix: correct types for aggregation funcs in t2d specify features
Browse files Browse the repository at this point in the history
  • Loading branch information
MartinBernstorff committed Jun 29, 2023
1 parent 6533ed9 commit 6796f0a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions psycop/projects/t2d/feature_generation/specify_features.py
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def _get_outcome_specs(self) -> list[OutcomeSpec]:
feature_base_name="first_diabetes_lab_result",
timeseries_df=get_first_diabetes_lab_result_above_threshold(),
lookahead_days=365,
aggregation_fn=max,
aggregation_fn=maximum,
fallback=0,
incident=True,
prefix=self.project_info.prefix.outcome,
Expand Down Expand Up @@ -334,7 +334,7 @@ def _get_temporal_predictor_specs(self) -> list[PredictorSpec]:
feature_base_name="hba1c",
timeseries_df=hba1c(),
lookbehind_days=9999,
aggregation_fn=max,
aggregation_fn=maximum,
fallback=np.nan,
prefix=self.project_info.prefix.predictor,
),
Expand Down

0 comments on commit 6796f0a

Please sign in to comment.