Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: train cvd with v2 #455

Merged
merged 22 commits into from
Nov 20, 2023
Merged

feat: train cvd with v2 #455

merged 22 commits into from
Nov 20, 2023

Conversation

MartinBernstorff
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023 •
edited
Loading

Looks like your PR modifies shared library files in psycop/common/.

We highly recommend getting your code reviewed by one of the core maintainers to avoid breaking other projects that depend on these files :-)

@MartinBernstorff MartinBernstorff mentioned this pull request Nov 17, 2023
Closed
HLasse
HLasse approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@HLasse HLasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, Martin! It's great seeing that our re-factoring has worked! Fan of all the functions you have registered - I suggest moving them all to common

psycop/projects/cvd/model_training/data_loader/trainval_loader.py Show resolved Hide resolved
psycop/projects/cvd/model_training/preprocessing/bool_to_int.py Show resolved Hide resolved
psycop/projects/cvd/model_training/preprocessing/datetime_filter.py Show resolved Hide resolved
psycop/projects/cvd/model_training/preprocessing/regex_filter.py Show resolved Hide resolved
@MartinBernstorff MartinBernstorff merged commit 6f66569 into main Nov 20, 2023
5 checks passed
@MartinBernstorff MartinBernstorff deleted the mbern_train_cvd_with_v2 branch November 20, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HLasse HLasse HLasse approved these changes

@sarakolding sarakolding Awaiting requested review from sarakolding

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinBernstorff @HLasse