returning false or nil from safe_converter could be problematic for

boolean values

.rubocop.yml

@@ -26,6 +26,8 @@ Layout/MultilineOperationIndentation:
 Metrics/BlockLength:
  Exclude:
  - spec/**/*
+Metrics/MethodLength:
+ Max: 15
 Style/FrozenStringLiteralComment:
  Exclude:
  - '**/*.gemspec'

lib/active_interaction/filter.rb

@@ -173,7 +173,7 @@ def default?
  # @private
  # rubocop:disable Metrics/MethodLength
  def cast(value, context, convert: true, reconstantize: true)
- if safe_matches?(value)
+ if matches?(value)
  adjust_output(value, context)
  # we can't use `nil?` because BasicObject doesn't have it
  elsif value == nil # rubocop:disable Style/NilComparison
@@ -186,7 +186,7 @@ def cast(value, context, convert: true, reconstantize: true)
  reconstantize: false
  )
  elsif convert
- public_send(__method__, safe_convert(value), context,
+ public_send(__method__, convert(value), context,
  convert: false,
  reconstantize: reconstantize
  )
@@ -217,12 +217,6 @@ def matches?(_value)
  false
  end
 
- def safe_matches?(value)
- matches?(value)
- rescue NoMethodError
- false
- end
-
  def adjust_output(value, _context)
  value
  end
@@ -231,12 +225,6 @@ def convert(value)
  value
  end
 
- def safe_convert(value)
- convert(value)
- rescue NoMethodError
- false
- end
-
  # @param value [Object]
  # @return [String]
  def describe(value)

lib/active_interaction/filters/abstract_date_time_filter.rb

@@ -20,6 +20,8 @@ def klasses
 
  def matches?(value)
  klasses.any? { |klass| value.is_a?(klass) }
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def convert(value)
@@ -32,6 +34,8 @@ def convert(value)
  end
  rescue ArgumentError
  value
+ rescue NoMethodError # BasicObject
+ super
  end
 
  def convert_string(value)

lib/active_interaction/filters/abstract_numeric_filter.rb

@@ -15,6 +15,8 @@ def database_column_type
 
  def matches?(value)
  value.is_a?(klass)
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def convert(value)
@@ -27,6 +29,8 @@ def convert(value)
  else
  super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
 
  def converter(value)

lib/active_interaction/filters/array_filter.rb

@@ -49,6 +49,8 @@ def klasses
 
  def matches?(value)
  klasses.any? { |klass| value.is_a?(klass) }
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def adjust_output(value, context)
@@ -62,8 +64,10 @@ def convert(value)
  if value.respond_to?(:to_ary)
  value.to_ary
  else
- value
+ super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
 
  def add_option_in_place_of_name(klass, options)

lib/active_interaction/filters/boolean_filter.rb

@@ -26,6 +26,8 @@ def database_column_type
 
  def matches?(value)
  value.is_a?(TrueClass) || value.is_a?(FalseClass)
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def convert(value)
@@ -37,6 +39,8 @@ def convert(value)
  else
  super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
  end
 end

lib/active_interaction/filters/hash_filter.rb

@@ -29,6 +29,8 @@ class HashFilter < Filter
 
  def matches?(value)
  value.is_a?(Hash)
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def clean_value(hash, name, filter, value, context)
@@ -55,8 +57,10 @@ def convert(value)
  if value.respond_to?(:to_hash)
  value.to_hash
  else
- value
+ super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
 
  # rubocop:disable Style/MissingRespondToMissing, Style/MethodMissingSuper

lib/active_interaction/filters/string_filter.rb

@@ -28,6 +28,8 @@ def strip?
 
  def matches?(value)
  value.is_a?(String)
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def adjust_output(value, _context)
@@ -38,8 +40,10 @@ def convert(value)
  if value.respond_to?(:to_str)
  value.to_str
  else
- value
+ super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
  end
 end

lib/active_interaction/filters/symbol_filter.rb

@@ -20,6 +20,8 @@ class SymbolFilter < Filter
 
  def matches?(value)
  value.is_a?(Symbol)
+ rescue NoMethodError # BasicObject
+ false
  end
 
  def convert(value)
@@ -28,6 +30,8 @@ def convert(value)
  else
  super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
  end
 end

lib/active_interaction/filters/time_filter.rb

@@ -57,6 +57,8 @@ def convert(value)
  else
  super
  end
+ rescue NoMethodError # BasicObject
+ super
  end
  end
 end