Skip to content

Commit

Permalink
update tests to avoid monkeypatching
Browse files Browse the repository at this point in the history
  • Loading branch information
AaronLasseigne committed Nov 8, 2022
1 parent a809464 commit 2129e47
Show file tree
Hide file tree
Showing 51 changed files with 56 additions and 139 deletions.
1 change: 1 addition & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
--require spec_helper
--color
--order rand
4 changes: 1 addition & 3 deletions spec/active_interaction/array_input_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::ArrayInput do
RSpec.describe ActiveInteraction::ArrayInput do
subject(:input) do
described_class.new(filter,
value: value,
Expand Down
3 changes: 1 addition & 2 deletions spec/active_interaction/base_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require 'spec_helper'
require 'action_controller'
require 'active_support/core_ext/kernel/reporting'

Expand Down Expand Up @@ -34,7 +33,7 @@ def execute
end
end

describe ActiveInteraction::Base do
RSpec.describe ActiveInteraction::Base do
subject(:interaction) { described_class.new(inputs) }

include_context 'interactions'
Expand Down
6 changes: 2 additions & 4 deletions spec/active_interaction/concerns/active_modelable_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

shared_examples_for 'ActiveModel' do
RSpec.shared_examples_for 'ActiveModel' do
it 'includes ActiveModel::Conversion' do
expect(subject).to be_a_kind_of ActiveModel::Conversion
end
Expand All @@ -14,7 +12,7 @@
end
end

describe ActiveInteraction::ActiveModelable do
RSpec.describe ActiveInteraction::ActiveModelable do
include_context 'concerns', described_class

it_behaves_like 'ActiveModel'
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/concerns/active_recordable_spec.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
require 'spec_helper'

InteractionWithFloatFilter = Class.new(TestInteraction) do
float :thing
end

describe ActiveInteraction::ActiveRecordable do
RSpec.describe ActiveInteraction::ActiveRecordable do
include_context 'interactions'

let(:described_class) { InteractionWithFloatFilter }
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/concerns/hashable_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::Hashable do
RSpec.describe ActiveInteraction::Hashable do
include_context 'concerns', described_class

describe '#hash(*args, &block)' do
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/concerns/missable_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::Missable do
RSpec.describe ActiveInteraction::Missable do
include_context 'concerns', described_class

describe '#respond_to?(slug, include_all = false)' do
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/concerns/runnable_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::Runnable do
RSpec.describe ActiveInteraction::Runnable do
include_context 'concerns', described_class

class WrappableFailingInteraction # rubocop:disable Lint/ConstantDefinitionInBlock
Expand Down
3 changes: 1 addition & 2 deletions spec/active_interaction/errors_spec.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require 'spec_helper'
require 'active_record'
require 'sqlite3'

Expand All @@ -7,7 +6,7 @@
database: ':memory:'
)

describe ActiveInteraction::Errors do
RSpec.describe ActiveInteraction::Errors do
subject(:errors) { described_class.new(klass.new) }

let(:klass) do
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filter/column_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::Filter::Column do
RSpec.describe ActiveInteraction::Filter::Column do
subject(:column) { described_class.intern(type) }

let(:type) { :float }
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::Filter, :filter do
RSpec.describe ActiveInteraction::Filter, :filter do
include_context 'filters'

describe '#database_column_type' do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::AbstractDateTimeFilter, :filter do
RSpec.describe ActiveInteraction::AbstractDateTimeFilter, :filter do
include_context 'filters'

describe '#process' do
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::AbstractNumericFilter, :filter do
RSpec.describe ActiveInteraction::AbstractNumericFilter, :filter do
include_context 'filters'

describe '#process' do
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/array_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::ArrayFilter, :filter do
RSpec.describe ActiveInteraction::ArrayFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/boolean_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::BooleanFilter, :filter do
RSpec.describe ActiveInteraction::BooleanFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/date_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::DateFilter, :filter do
RSpec.describe ActiveInteraction::DateFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/date_time_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::DateTimeFilter, :filter do
RSpec.describe ActiveInteraction::DateTimeFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/decimal_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::DecimalFilter, :filter do
RSpec.describe ActiveInteraction::DecimalFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/file_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::FileFilter, :filter do
RSpec.describe ActiveInteraction::FileFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
3 changes: 1 addition & 2 deletions spec/active_interaction/filters/float_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
require 'bigdecimal'
require 'spec_helper'

describe ActiveInteraction::FloatFilter, :filter do
RSpec.describe ActiveInteraction::FloatFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/hash_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::HashFilter, :filter do
RSpec.describe ActiveInteraction::HashFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/integer_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::IntegerFilter, :filter do
RSpec.describe ActiveInteraction::IntegerFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/interface_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
require 'spec_helper'

module InterfaceModule; end

class InterfaceClass; end # rubocop:disable Lint/EmptyClass

describe ActiveInteraction::InterfaceFilter, :filter do
RSpec.describe ActiveInteraction::InterfaceFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter' do
let(:name) { :interface_module }
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/object_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

class ObjectThing
def self.converter(_)
@converter ||= new
Expand All @@ -13,7 +11,7 @@ def self.converter_with_error(_)
class ObjectThings; end # rubocop:disable Lint/EmptyClass
BackupObjectThing = ObjectThing

describe ActiveInteraction::ObjectFilter, :filter do
RSpec.describe ActiveInteraction::ObjectFilter, :filter do
include_context 'filters'
before do
options[:class] = ObjectThing
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/record_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

class RecordThing
def self.find(_)
raise 'error'
Expand All @@ -21,7 +19,7 @@ def self.finds_bad_value(_)
class RecordThings; end # rubocop:disable Lint/EmptyClass
BackupRecordThing = RecordThing

describe ActiveInteraction::RecordFilter, :filter do
RSpec.describe ActiveInteraction::RecordFilter, :filter do
include_context 'filters'
before do
options[:class] = RecordThing
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/string_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::StringFilter, :filter do
RSpec.describe ActiveInteraction::StringFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/symbol_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::SymbolFilter, :filter do
RSpec.describe ActiveInteraction::SymbolFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/filters/time_filter_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::TimeFilter, :filter do
RSpec.describe ActiveInteraction::TimeFilter, :filter do
include_context 'filters'
it_behaves_like 'a filter'

Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/grouped_input_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::GroupedInput do
RSpec.describe ActiveInteraction::GroupedInput do
subject(:grouped_input) { described_class.new }

it 'subclasses OpenStruct' do
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/hash_input_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::HashInput do
RSpec.describe ActiveInteraction::HashInput do
subject(:input) do
described_class.new(filter,
value: value,
Expand Down
6 changes: 2 additions & 4 deletions spec/active_interaction/i18n_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction do
RSpec.describe ActiveInteraction do
context 'I18n.load_path' do
it 'contains localization file paths' do
expect(I18n.load_path)
Expand All @@ -20,7 +18,7 @@
.keys
.map(&:to_s)

describe I18nInteraction do
RSpec.describe I18nInteraction do
include_context 'interactions'

shared_examples 'translation' do |locale|
Expand Down
4 changes: 1 addition & 3 deletions spec/active_interaction/inputs_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
require 'spec_helper'

describe ActiveInteraction::Inputs do
RSpec.describe ActiveInteraction::Inputs do
subject(:inputs) { described_class.new(args, base_class.new) }

let(:args) { {} }
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
require 'spec_helper'
require 'active_record'
require 'sqlite3'

Expand Down Expand Up @@ -29,7 +28,7 @@ class Element < ActiveRecord::Base
end
end

describe ArrayInteraction do
RSpec.describe ArrayInteraction do
include_context 'interactions'
it_behaves_like 'an interaction', :array, -> { [] }
it_behaves_like 'an interaction', :array, -> { Element.where('1 = 1') }, ->(result) { result.to_a }
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

describe 'BooleanInteraction' do
RSpec.describe 'BooleanInteraction' do
it_behaves_like 'an interaction', :boolean, -> { [false, true].sample }
end
4 changes: 1 addition & 3 deletions spec/active_interaction/integration/date_interaction_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

describe 'DateInteraction' do
RSpec.describe 'DateInteraction' do
it_behaves_like 'an interaction', :date, -> { Date.today }
end
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

describe 'DateTimeInteraction' do
RSpec.describe 'DateTimeInteraction' do
it_behaves_like 'an interaction', :date_time, -> { DateTime.now }
end
3 changes: 1 addition & 2 deletions spec/active_interaction/integration/file_interaction_spec.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
require 'spec_helper'
require 'action_dispatch'

FileInteraction = Class.new(TestInteraction) do
file :a
end

describe FileInteraction do
RSpec.describe FileInteraction do
include_context 'interactions'
it_behaves_like 'an interaction', :file, -> { File.open(__FILE__) }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

describe 'FloatInteraction' do
RSpec.describe 'FloatInteraction' do
it_behaves_like 'an interaction', :float, -> { rand }
end
4 changes: 1 addition & 3 deletions spec/active_interaction/integration/hash_interaction_spec.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

HashInteraction = Class.new(TestInteraction) do
hash :a do
hash :x
Expand All @@ -9,7 +7,7 @@
end
end

describe HashInteraction do
RSpec.describe HashInteraction do
include_context 'interactions'
it_behaves_like 'an interaction', :hash, -> { {} }

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require 'spec_helper'

describe 'IntegerInteraction' do
RSpec.describe 'IntegerInteraction' do
it_behaves_like 'an interaction', :integer, -> { rand(1 << 16) }
end
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
require 'spec_helper'
require 'json'
require 'yaml'

InterfaceInteraction = Class.new(TestInteraction) do
interface :anything, methods: []
end

describe InterfaceInteraction do
RSpec.describe InterfaceInteraction do
include_context 'interactions'
it_behaves_like 'an interaction',
:interface,
Expand Down
Loading

0 comments on commit 2129e47

Please sign in to comment.