-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename model filter to object filter? #264
Comments
> Class.ancestors
=> [Class, Module, Object, Kernel, BasicObject] It also seems to more clearly indicate the fact that it can be used for modules. |
I think this is a good change. |
tfausak
added a commit
that referenced
this issue
Mar 16, 2015
This was referenced Mar 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The model filter doesn't really define a model. It defines an object. More specifically, it defines an instance of a class. For instance, if you want a
Proc
input, you have to do this:That doesn't really make sense to me. I think this would be better:
I think we ended up with
model
because we usually use this filter for ActiveModel objects. But it's designed to work with anything. I think we should change the name to reflect that.The text was updated successfully, but these errors were encountered: