Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename model filter to object filter? #264

Closed
tfausak opened this issue Mar 12, 2015 · 2 comments
Closed

Rename model filter to object filter? #264

tfausak opened this issue Mar 12, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@tfausak
Copy link
Collaborator

tfausak commented Mar 12, 2015

The model filter doesn't really define a model. It defines an object. More specifically, it defines an instance of a class. For instance, if you want a Proc input, you have to do this:

model :proc

That doesn't really make sense to me. I think this would be better:

object :proc

I think we ended up with model because we usually use this filter for ActiveModel objects. But it's designed to work with anything. I think we should change the name to reflect that.

@AaronLasseigne
Copy link
Owner

> Class.ancestors
=> [Class, Module, Object, Kernel, BasicObject]

It also seems to more clearly indicate the fact that it can be used for modules.

@AaronLasseigne
Copy link
Owner

I think this is a good change.

@tfausak tfausak self-assigned this Mar 16, 2015
@tfausak tfausak added this to the v2.0.0 milestone Mar 16, 2015
tfausak added a commit that referenced this issue Mar 17, 2015
Conflicts:
	lib/active_interaction.rb
@tfausak tfausak closed this as completed Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants