Use Rails 5-style detailed errors #276
Conversation
|
This build failed because active_model-errors_details depends on activemodel >= 4.0, whereas active_interaction depends on activemodel ~> 3.2. |
|
I am now waiting on cowbell/active_model-errors_details#2 to add support for Rails 3.2. |
|
My pull request was merged and released as v1.2.0. However it requires ActiveModel >=3.2.13, whereas we require ActiveModel >=3.2.0. |
The latest version (1.2.0) of active_model-errors_details requires
a newer version (3.2.13) of activemodel than we do.
This commit embeds the source of active_model-errors_details to
avoid the dependency conflict. Note that it's not exactly the same.
I modified it in two notable ways:
1. I removed the backwards-compatible #deep_dup. Whatever ActiveModel
uses is sufficient for us.
2. I cleaned up and refactored the source a little.
|
39f2dd7 added 3.2.0-compatible support for the detailed errors. |
|
I realized that this is technically a backport, so I moved it into the backports file. |
|
|
||
| %w[initialize initialize_dup add clear delete].each do |method| | ||
| alias_method "#{method}_without_details", method | ||
| alias_method method, "#{method}_with_details" |
There was a problem hiding this comment.
👍
At some point along the way, it was not working for me. Now it is. I am not sure what changed.
|
We need to update the README to reflect these changes. (probably for some of the other 2.0 stuff as well) |
|
Code wise it's a |
.
|
I'll update the v2.0.0 documentation in a separate branch. |
Fixes #250.