Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for invalid classes #304

Merged
merged 1 commit into from
Oct 2, 2015
Merged

Conversation

tfausak
Copy link
Collaborator

@tfausak tfausak commented Oct 2, 2015

This pull request is in response to #302. It changes the InvalidClassError message. If you define an object filter for a class that doesn't exist, the message can be confusing.

class Example < ActiveInteraction::Base
  object :cow
end
Example.run
# ActiveInteraction::InvalidClassError: "Cow"

The class is invalid to ActiveInteraction because it doesn't exist. The new error message is hopefully better.

Example.run
# ActiveInteraction::InvalidClassError: class "Cow" does not exist

@tfausak tfausak self-assigned this Oct 2, 2015
@AaronLasseigne
Copy link
Owner

I like this.

@tfausak tfausak merged commit ab972eb into master Oct 2, 2015
@tfausak tfausak deleted the gh-302-class-error branch October 2, 2015 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants