-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: If GetCurrentAppDomainId fails try GetDefaultDomain first (.netframework remote start issue) #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you! I didn't test the remote thread activation path. There is also a lot of confusion around this style of activation in in .NET Framework. If the below works for you, please commit the suggestions and I will merge the PR.
So sorry forgot to do as requested and follow up on this! |
No worries. We all get busy with the constant in/out of PRs and requested changes. I didn't want to step on your effort so I didn't do it myself. However, I like this fix and want to get it in this week :-) |
a .net framework issue
4d121f7
to
24c2136
Compare
Thanks @mitchcapper ! |
@mitchcapper A new package with these changes has been release - https://www.nuget.org/packages/DNNE/2.0.6 |
Thanks for a fantastic library!
This does 3 things, if you want it split into 3 commits let me know: