Add TLS end to end unit test #1
Conversation
| @@ -18,4 +18,8 @@ public sealed record ClientTlsOptions | |||
| public bool UseTls { get; init; } = false; | |||
|
|
|||
| public SslClientAuthenticationOptions? SslOptions { get; init; } | |||
|
|
|||
| public RemoteCertificateValidationCallback? ServerCertificateValidator { get; set; } | |||
There was a problem hiding this comment.
These are both built into SslClientAuthenticationOptions https://learn.microsoft.com/en-us/dotnet/api/system.net.security.sslclientauthenticationoptions?view=net-8.0#properties - let's use those properties instead
| @@ -53,6 +53,9 @@ public MqttClientFactory(ActorSystem system) | |||
| public async Task<IMqttClient> CreateTcpClient(MqttClientConnectOptions options, MqttClientTcpOptions tcpOptions) | |||
| { | |||
| AssertMqtt311(options); | |||
| if (tcpOptions.TlsOptions is { UseTls: true, SslOptions: null }) | |||
| throw new NullReferenceException("TlsOptions.SslOptions can not be null if TlsOptions.UseTls is true"); | |||
| public SslServerAuthenticationOptions? SslOptions { get; set; } | ||
| public SslServerAuthenticationOptions? SslOptions { get; init; } | ||
|
|
||
| public RemoteCertificateValidationCallback? ClientCertificateValidator { get; init; } |
There was a problem hiding this comment.
Same feedback as earlier - SslServerAuthenticationOptions also contains these properties: https://learn.microsoft.com/en-us/dotnet/api/system.net.security.sslserverauthenticationoptions?view=net-8.0 - let's use those
| @@ -0,0 +1,17 @@ | |||
| -----BEGIN CERTIFICATE REQUEST----- | |||
There was a problem hiding this comment.
Did my old certs not work correctly?
There was a problem hiding this comment.
I also needed the self-signed root CA certificate that signs the server certificate, that's why I needed to rebuild all of the certs
| } | ||
|
|
||
| [Fact] | ||
| public async Task ShouldAutomaticallyReconnectAndSubscribeAfterServerDisconnect() |
There was a problem hiding this comment.
Would it be better if we just made the TCP end 2 end specs sub-classable and reuse those @Arkatufus ?
No description provided.