Require latest spice and ragdaemon #565
Conversation
![mentatbot[bot]](https://avatars.githubusercontent.com/in/837875?s=60&v=4){kind=small}
| @@ -17,12 +17,12 @@ pytest-mock==3.11.1 | |||
| pytest-reportlog==0.4.0 | |||
| pytest-timeout==2.2.0 | |||
| python-dotenv==1.0.0 | |||
| ragdaemon==0.1.5 | |||
| ragdaemon~=0.1.0 | |||
There was a problem hiding this comment.
Using ~=0.1.0 for ragdaemon will allow minor updates but might introduce breaking changes if ragdaemon follows Semantic Versioning and introduces breaking changes in 0.2.0. Consider specifying a more precise version range if stability is a concern.
| selenium==4.15.2 | ||
| sentry-sdk==1.34.0 | ||
| sounddevice==0.4.6 | ||
| soundfile==0.12.1 | ||
| spiceai==0.1.11 | ||
| spiceai~=0.1.0 |
There was a problem hiding this comment.
The use of ~=0.1.0 for spiceai follows the same concern as ragdaemon. It's great for staying up-to-date with the latest features but be cautious of potential breaking changes in minor versions.
|
MENTAT CODE REVIEW IN ACTIVE DEVELOPMENT. Only in use on mentat and internal repos. The changes align with the goal of keeping dependencies up-to-date with the latest minor versions. However, it's important to consider the potential risks of automatically updating to new minor versions, especially for libraries that may not strictly follow Semantic Versioning. It might be worth discussing or documenting the strategy for handling any breaking changes that could arise from these updates. |
use
~=0.1.xto always fetch latest minor version of spiceai and ragdaemon.Pull Request Checklist