[pull] develop from misskey-dev:develop #120

pull · 2024-11-19T20:12:02Z

See Commits and Changes for more details.

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Bug Fixes:

Fix the issue where moderation logs were not functioning during account deletion.

* アカウント削除のモデレーションログが動作していないのを修正 * update CHANGELOG

cr-gpt · 2024-11-19T20:12:06Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

sourcery-ai · 2024-11-19T20:12:08Z

Reviewer's Guide by Sourcery

This PR modifies the account deletion functionality to include the moderator information when deleting accounts through admin endpoints. The changes ensure proper logging of account deletion actions by passing the moderator's user context to the deletion service.

Sequence diagram for account deletion with moderator context

sequenceDiagram
    actor Admin
    participant Endpoint
    participant UsersRepository
    participant DeleteAccountService
    Admin->>Endpoint: Request to delete account
    Endpoint->>UsersRepository: findOneByOrFail(userId)
    UsersRepository-->>Endpoint: User
    Endpoint->>DeleteAccountService: deleteAccount(user, me)
    DeleteAccountService-->>Endpoint: Account deleted
    Endpoint-->>Admin: Confirmation

Updated class diagram for DeleteAccountService usage

classDiagram
    class Endpoint {
        - meta
        - paramDef
        - usersRepository
        - deleteAccountService
        + constructor(meta, paramDef, usersRepository, deleteAccountService)
        + deleteAccount(userId, me)
    }
    class DeleteAccountService {
        + deleteAccount(user, me)
    }
    Endpoint --> DeleteAccountService

File-Level Changes

Change	Details	Files
Updated account deletion endpoints to include moderator information	Added moderator user context parameter to deleteAccount service calls Fixed account deletion moderation logging functionality	`packages/backend/src/server/api/endpoints/admin/delete-account.ts` `packages/backend/src/server/api/endpoints/admin/accounts/delete.ts`
Updated changelog with recent fixes	Added entry for account deletion moderation logging fix (アカウント削除のモデレーションログが動作していない misskey-dev/misskey#14996)	`CHANGELOG.md`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time. You can also use
this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

github-actions · 2024-11-19T20:14:06Z

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

* Mod: 絵文字のポップアップメニューに編集を追加 * fix: code styleの修正 * fix: code styleの修正 * fix

cr-gpt · 2024-11-20T11:08:31Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

) * wip * Update CHANGELOG.md * wip

cr-gpt · 2024-11-20T22:58:38Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* fix(backend): renoteMute doesn't work for note notification * docs(changelog): update changelog

cr-gpt · 2024-11-20T23:00:54Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (German)

cr-gpt · 2024-11-20T23:01:45Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* enhance: Add a few validation fixes from Sharkey See the original MR on the GitLab instance: https://activitypub.software/TransFem-org/Sharkey/-/merge_requests/484 Co-Authored-By: Dakkar <dakkar@thenautilus.net> * fix: primitive 2: acceptance of cross-origin alternate Co-Authored-By: Laura Hausmann <laura@hausmann.dev> * fix: primitive 3: validation of non-final url * fix: primitive 4: missing same-origin identifier validation of collection-wrapped activities * fix: primitives 5 & 8: reject activities with non string identifiers Co-Authored-By: Laura Hausmann <laura@hausmann.dev> * fix: primitive 6: reject anonymous objects that were fetched by their id * fix: primitives 9, 10 & 11: http signature validation doesn't enforce required headers or specify auth header name Co-Authored-By: Laura Hausmann <laura@hausmann.dev> * fix: primitive 14: improper validation of outbox, followers, following & shared inbox collections * fix: code style for primitive 14 * fix: primitive 15: improper same-origin validation for note uri and url Co-Authored-By: Laura Hausmann <laura@hausmann.dev> * fix: primitive 16: improper same-origin validation for user uri and url * fix: primitive 17: note same-origin identifier validation can be bypassed by wrapping the id in an array * fix: code style for primitive 17 * fix: check attribution against actor in notes While this isn't strictly required to fix the exploits at hand, this mirrors the fix in `ApQuestionService` for GHSA-5h8r-gq97-xv69, as a preemptive countermeasure. * fix: primitive 18: `ap/get` bypasses access checks One might argue that we could make this one actually preform access checks against the returned activity object, but I feel like that's a lot more work than just restricting it to administrators, since, to me at least, it seems more like a debugging tool than anything else. * fix: primitive 19 & 20: respect blocks and hide more Ideally, the user property should also be hidden (as leaving it in leaks information slightly), but given the schema of the note endpoint, I don't think that would be possible without introducing some kind of "ghost" user, who is attributed for posts by users who have you blocked. * fix: primitives 21, 22, and 23: reuse resolver This also increases the default `recursionLimit` for `Resolver`, as it theoretically will go higher that it previously would and could possibly fail on non-malicious collection activities. * fix: primitives 25-33: proper local instance checks * revert: fix: primitive 19 & 20 This reverts commit 465a9fe6591de90f78bd3d084e3c01e65dc3cf3c. --------- Co-authored-by: Dakkar <dakkar@thenautilus.net> Co-authored-by: Laura Hausmann <laura@hausmann.dev> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>

cr-gpt · 2024-11-20T23:20:13Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* Fix poll update spoofing * fix: Disallow negative poll counts --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>

cr-gpt · 2024-11-20T23:24:54Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* fix(backend): check target IP before sending HTTP request * fix(backend): allow accessing private IP when testing * Apply suggestions from code review Co-authored-by: anatawa12 <anatawa12@icloud.com> * fix(backend): lint and typecheck * fix(backend): add isLocalAddressAllowed option to getAgentByUrl and send (HttpRequestService) * fix(backend): allow fetchSummaryFromProxy, trueMail to access local addresses --------- Co-authored-by: anatawa12 <anatawa12@icloud.com> Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>

cr-gpt · 2024-11-20T23:27:13Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Co-Authored-By: Acid Chicken <root@acid-chicken.com>

cr-gpt · 2024-11-21T00:22:20Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2024-11-21T00:25:23Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2024-11-21T01:30:34Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* Fix type error in security fixes (cherry picked from commit fa3cf6c) * Fix error in test function calls (cherry picked from commit 1758f29) * Fix style error (cherry picked from commit 23c4aa2) * Fix another style error (cherry picked from commit 36af07a) * Fix `.punyHost` misuse (cherry picked from commit 6027b51) * attempt to fix test: make yaml valid --------- Co-authored-by: Julia Johannesen <julia@insertdomain.name>

cr-gpt · 2024-11-21T03:10:07Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

* fix(backend): fix apResolver * fix * add comments * tweak comment

cr-gpt · 2024-11-21T05:36:27Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2024-11-21T06:28:15Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2024-11-21T06:41:04Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2024-11-21T08:16:10Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

cr-gpt · 2024-11-21T08:21:58Z

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Fix(backend): アカウント削除のモデレーションログが動作していないのを修正 (#14996) (#14997)

763c708

* アカウント削除のモデレーションログが動作していないのを修正 * update CHANGELOG

pull bot added the ⤵️ pull label Nov 19, 2024

github-actions bot added the packages/backend label Nov 19, 2024

feat: 絵文字のポップアップメニューに編集を追加 (#15004)

4603ab6

* Mod: 絵文字のポップアップメニューに編集を追加 * fix: code styleの修正 * fix: code styleの修正 * fix

github-actions bot added the packages/frontend label Nov 20, 2024

perf(frontend): reduce api requests for non-logged-in enviroment (#15001

f0c3a4c

) * wip * Update CHANGELOG.md * wip

Fix: リノートミュートが新規投稿通知に対して作用していなかった問題を修正 (#15006)

aa48a0e

* fix(backend): renoteMute doesn't work for note notification * docs(changelog): update changelog

New Crowdin updates (#15000)

1c284c8

* New translations ja-jp.yml (Catalan) * New translations ja-jp.yml (English) * New translations ja-jp.yml (Korean) * New translations ja-jp.yml (Chinese Simplified) * New translations ja-jp.yml (Chinese Traditional) * New translations ja-jp.yml (German)

Merge commit from fork

b9cb949

* Fix poll update spoofing * fix: Disallow negative poll counts --------- Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>

fix(backend): use atomic command to improve security

9fdabe3

Co-Authored-By: Acid Chicken <root@acid-chicken.com>

fix ap/show

0f59adc

fix(backend): fix security patches (#15008)

53e827b

github-actions bot added the packages/backend:test label Nov 21, 2024

fix(backend): fix apResolver (#15010)

c1f19fa

* fix(backend): fix apResolver * fix * add comments * tweak comment

Bump version to 2024.11.0-alpha.3

a21a2c5

Update CHANGELOG.md

9871035

github-actions bot added the packages/misskey-js label Nov 21, 2024

Update CHANGELOG.md

7f0ae03

Bump version to 2024.11.0-beta.4

752606f

pull bot merged commit 752606f into Abaso007:develop Nov 21, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pull] develop from misskey-dev:develop #120

[pull] develop from misskey-dev:develop #120

pull bot commented Nov 19, 2024 •

edited by sourcery-ai bot

Loading

cr-gpt bot commented Nov 19, 2024

sourcery-ai bot commented Nov 19, 2024 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

github-actions bot commented Nov 19, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

[pull] develop from misskey-dev:develop #120

[pull] develop from misskey-dev:develop #120

Conversation

pull bot commented Nov 19, 2024 • edited by sourcery-ai bot Loading

Summary by Sourcery

cr-gpt bot commented Nov 19, 2024

sourcery-ai bot commented Nov 19, 2024 • edited Loading

Reviewer's Guide by Sourcery

Sequence diagram for account deletion with moderator context

Updated class diagram for DeleteAccountService usage

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

github-actions bot commented Nov 19, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 20, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

cr-gpt bot commented Nov 21, 2024

pull bot commented Nov 19, 2024 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Nov 19, 2024 •

edited

Loading