-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup #523
Cleanup #523
Conversation
To resolve merge conflicts after this PR has been merged:
note that these are destructive and powerful git commands. |
@clragon -- I merged the code but after upgrading to flutter 3.15.3 (or whatever) 2 tests fail so I am not going to publish this yet ... can you submit fixes for the tests -- here is the output ... …/master/flutter_typeahead c6ff9b2 master ⍟4 flutter test 1 ↵ 10013 16:53:01 When the exception was thrown, this was the stack: This was caught by the test expectation on the following line: To run this test again: /Users/sjm/Development/tools/flutter/bin/cache/dart-sdk/bin/dart test /Users/sjm/play/master/flutter_typeahead/test/cupertino_typeahead_test.dart -p vm --plain-name 'Cupertino TypeAhead widget tests Initial UI Test' When the exception was thrown, this was the stack: This was caught by the test expectation on the following line: To run this test again: /Users/sjm/Development/tools/flutter/bin/cache/dart-sdk/bin/dart test /Users/sjm/play/master/flutter_typeahead/test/material_typeahead_test.dart -p vm --plain-name 'Material TypeAhead widget tests Initial UI Test' |
certainly, I will take a look. |
This PR includes:
For future PRs to be considered:
flutter_keyboard_visibility
supports all platforms except web.this
.ThemeData