Generalised Custom Attribute #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this took a bit longer than I had previously anticipated.
As we move toward Donor implementation, it occurred to me that we'd be better off having a generalised approach to custom attributes. This means that instead of having a Custom Sample Attribute or a Custom Donor Attribute, we just have a Custom Attribute. This is added by using the Attribute Portal:
When the user adds an attribute, they are greeted with this form:
Wherein the user is able to associate an attribute to one, or all database elements (Donor, Sample, Storage etc).
In addition to this, I've removed the dependency of inflect - as well as begun playing with ontology-aided form creation. This can be seen when attempting to add a numeric custom attribute, LImBuS will pull measurements and prefixes from UO.
Oh, and clear_session is now in misc. I'll have to fix this before I merge - so give me a couple minutes after I've typed this up.