Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is now asked to confirm when a Protocol Event is to be disposed. #80

Merged
merged 1 commit into from
May 25, 2021

Conversation

KeironO
Copy link
Collaborator

@KeironO KeironO commented May 25, 2021

Description

Client complained about the immediate nature in which Protocol Events are removed, this PR resolves that by adding a modal:

image

When the Remove button is pressed. The user is shown a modal asking for them to write in the Protocol Event UUID:

image

Once the UUID is entered, the user is then able to continue with the removal.

Fixes #78

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@KeironO KeironO merged commit ef75eb4 into dev May 25, 2021
@KeironO KeironO deleted the protocol-event-deletion-confirmation branch May 25, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional confirmation when deleting Protocol Event.
1 participant