Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampletype fix - actually some fixes for storage #93

Merged
merged 26 commits into from
Jul 23, 2021
Merged

Conversation

pipaLU
Copy link
Contributor

@pipaLU pipaLU commented Jul 23, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

  • Allow lock/delete storage entities: site/building/room/shelf
  • Fix issues of assigning a sample/rack to multiple shelf
  • change in datatables.net-select version to 1.3.3 and add relevant css file

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

wiw14 and others added 26 commits July 14, 2021 14:53
Minor Fixes:
-added range validator to rack row and column input fields
Minor issues fixed:
-room count was displaying site count
-county site information wasn't being saved
-site data displayed with null values in table
Delete button for the site only appears when there are no associated buildings and the user is an admin.

Delete button for the room and building fails if there is an associated cold storage.
Minor issues fixed:
- added new button to rackToShelf form, allows the user to directly add a new rack
When an entity is locked the user can't bypass the lock by entering a url.
The delete popup has been changed to match better with the existing theme
@pipaLU pipaLU self-assigned this Jul 23, 2021
@pipaLU pipaLU merged commit 23a7be6 into dev Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants