add TypeScript types #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhyudayaSharma
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Thanks a lot for the PR @Snaptags ! It looks great but probably need to indent macro.d.ts using 2 spaces instead of 4, like the rest of the files.
|
Thanks for reminding me to reformat the file. |
|
Thanks a lot @Snaptags ! I will do a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for adding the TypeScript instructions to the README.
But instead of just adding the section you might as well provide a
*.d.tsfile.I tested this by installing the package locally and my IDE was able to pick up the types automatically.