Skip to content

Support pyenv on Windows #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2025
Merged

Support pyenv on Windows #94

merged 5 commits into from
Apr 25, 2025

Conversation

@nre-ableton
Copy link
Contributor

@nre-ableton nre-ableton commented Jun 29, 2022 •
edited by ala-ableton
Loading

This PR adds support for Windows in pyenv.createVirtualEnv(). I've bumped the minor version since this is technically a breaking change, as these functions previously resulted in an error being thrown when run on Windows.

@nre-ableton nre-ableton requested a review from a team as a code owner June 29, 2022 15:53
@nre-ableton nre-ableton requested review from ala-ableton and removed request for a team June 29, 2022 15:53
ala-ableton
ala-ableton requested changes Jul 7, 2022
View reviewed changes
@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from 0c705e7 to 1d876bc Compare July 7, 2022 17:19
@nre-ableton nre-ableton requested a review from ala-ableton July 7, 2022 17:31
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Jul 7, 2022

@ala-ableton my changes should squash cleanly. Let me know when I should squash.

ala-ableton
ala-ableton reviewed Jul 7, 2022
View reviewed changes
@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from bd05e01 to 9a325a1 Compare July 11, 2022 10:19
@nre-ableton nre-ableton requested a review from ala-ableton July 11, 2022 11:03
ala-ableton
ala-ableton requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ala-ableton ala-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix 31ed1db and we're almost done.

@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from 9a325a1 to 78189f0 Compare July 19, 2022 12:51
@nre-ableton nre-ableton requested a review from ala-ableton July 19, 2022 12:51
ala-ableton
ala-ableton requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ala-ableton ala-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 43d3b35, we now have export PATH=... twice.

@nre-ableton
Copy link
Contributor Author

nre-ableton commented Jul 19, 2022

In 43d3b35, we now have export PATH=... twice.

Sorry about that. Fixed in b5b1c96.

@nre-ableton nre-ableton requested a review from ala-ableton July 19, 2022 17:07
ala-ableton
ala-ableton requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@ala-ableton ala-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase/squash, then re-rebase and edit 43d3b35 to make sure that export PYENV_ROOT=... keeps on coming before export PATH=..., instead of having export PATH=... move around.

@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from b5b1c96 to 8f2a143 Compare July 19, 2022 17:57
@nre-ableton nre-ableton requested a review from ala-ableton July 19, 2022 17:57
ala-ableton
ala-ableton requested changes Jul 19, 2022
View reviewed changes
@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch 2 times, most recently from 732bd30 to 6381850 Compare July 28, 2022 08:44
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Jul 28, 2022

So I've rebased this PR, and also added Windows support for the newly-added integration tests, but they keep timing out after 1 hour.

The first time, the build failed with a different error (not a timeout):

[2022-07-28T08:33:57.000Z] F:/jenkins-node/workspace@tmp/durable-6cb19c97/script.sh: line 4: /f/jenkins-node/workspace/.venv/venv-95957963/Scripts/activate: No such file or directory

I've no idea why this is happening. 😞

@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch 5 times, most recently from 161f29f to 8c50355 Compare September 14, 2023 16:53
@nre-ableton nre-ableton marked this pull request as draft September 14, 2023 16:54
@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from 8c50355 to 240d754 Compare September 14, 2023 16:55
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Nov 29, 2024

@ala-ableton I've rebased this PR, ptal!

ala-ableton
ala-ableton requested changes Feb 13, 2025
View reviewed changes
@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from 4934877 to fb427d7 Compare February 13, 2025 13:33
@ala-ableton ala-ableton mentioned this pull request Mar 28, 2025
Merged
ala-ableton
ala-ableton requested changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@ala-ableton ala-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on the latest main state and drop the following commits:

@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from fb427d7 to 5e8dd21 Compare April 11, 2025 15:43
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Apr 11, 2025

I've rebased and edited the history as requested, but there are some failing tests that I will investigate next week. I will re-request a review once these have been fixed.

ala-ableton
ala-ableton reviewed Apr 14, 2025
View reviewed changes
@nre-ableton nre-ableton mentioned this pull request Apr 16, 2025
Merged
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Apr 16, 2025

@ala-ableton I fixed the issues with the tests, but I think that a preparation PR would be better for all the non-Windows-specific stuff. So I've opened up #164, which I assume you'll be interested in reviewing.

@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from 93e6052 to b9f3b29 Compare April 23, 2025 21:10
@nre-ableton nre-ableton requested a review from ala-ableton April 23, 2025 21:12
ala-ableton
ala-ableton requested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@ala-ableton ala-ableton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply changes similar to a4c566d to Windows-specific tests.

@nre-ableton
Assert pyenv install --list was called in test
592a3c8 
Should have been done in a4c566d.
@nre-ableton
Use pyenv exec when running pip install
8f0f23b 
This will facilitate Windows support, which will be added in a
future commit.
@nre-ableton
Export PYENV_VERSION rather than using pyenv shell
f83f73e 
This is needed to support pyenv on Windows.
@nre-ableton nre-ableton force-pushed the nre/master/2497-pyenv-windows branch from 03f59b6 to e97f829 Compare April 25, 2025 06:19
@nre-ableton nre-ableton requested a review from ala-ableton April 25, 2025 06:22
@ala-ableton ala-ableton force-pushed the nre/master/2497-pyenv-windows branch from 1c0f00f to 74e4f3c Compare April 25, 2025 10:18
@nre-ableton
Copy link
Contributor Author

nre-ableton commented Apr 25, 2025

@ala-ableton I’m ok with your fixup, so I’ll go ahead and squash

@nre-ableton
Copy link
Contributor Author

nre-ableton commented Apr 25, 2025

@ablbot autosquash

@ableton-ablbot
Copy link

ableton-ablbot bot commented Apr 25, 2025

Rebase job dfe5d703-6e82-417a-874b-6c2bd6cb89c0 has been created. There are currently 0 job(s) in the queue.

This message was generated by ablbot. For help: use @ablbot help, see @ablbot's documentation, or the Ableton CI Guide.

@ableton-ablbot
Copy link

ableton-ablbot bot commented Apr 25, 2025

Rebase of nre/master/2497-pyenv-windows onto main has succeeded.

This message was generated by ablbot. For help: use @ablbot help, see @ablbot's documentation, or the Ableton CI Guide.

@ableton-rebaser ableton-rebaser bot force-pushed the nre/master/2497-pyenv-windows branch from 74e4f3c to 0888d21 Compare April 25, 2025 10:45
ala-ableton
ala-ableton approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@ala-ableton ala-ableton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@nre-ableton nre-ableton merged commit c872d47 into main Apr 25, 2025
4 checks passed
@nre-ableton nre-ableton deleted the nre/master/2497-pyenv-windows branch April 25, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ala-ableton ala-ableton ala-ableton approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nre-ableton @ala-ableton