-
Notifications
You must be signed in to change notification settings - Fork 4
Support pyenv on Windows #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0c705e7
to
1d876bc
Compare
@ala-ableton my changes should squash cleanly. Let me know when I should squash. |
bd05e01
to
9a325a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix 31ed1db and we're almost done.
9a325a1
to
78189f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 43d3b35, we now have export PATH=...
twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase/squash, then re-rebase and edit 43d3b35 to make sure that export PYENV_ROOT=...
keeps on coming before export PATH=...
, instead of having export PATH=...
move around.
b5b1c96
to
8f2a143
Compare
732bd30
to
6381850
Compare
So I've rebased this PR, and also added Windows support for the newly-added integration tests, but they keep timing out after 1 hour. The first time, the build failed with a different error (not a timeout):
I've no idea why this is happening. 😞 |
161f29f
to
8c50355
Compare
8c50355
to
240d754
Compare
@ala-ableton I've rebased this PR, ptal! |
4934877
to
fb427d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fb427d7
to
5e8dd21
Compare
I've rebased and edited the history as requested, but there are some failing tests that I will investigate next week. I will re-request a review once these have been fixed. |
@ala-ableton I fixed the issues with the tests, but I think that a preparation PR would be better for all the non-Windows-specific stuff. So I've opened up #164, which I assume you'll be interested in reviewing. |
93e6052
to
b9f3b29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply changes similar to a4c566d to Windows-specific tests.
Should have been done in a4c566d.
This will facilitate Windows support, which will be added in a future commit.
This is needed to support pyenv on Windows.
03f59b6
to
e97f829
Compare
1c0f00f
to
74e4f3c
Compare
@ala-ableton I’m ok with your fixup, so I’ll go ahead and squash |
@ablbot autosquash |
Rebase job This message was generated by |
Rebase of This message was generated by |
74e4f3c
to
0888d21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
This PR adds support for Windows in
pyenv.createVirtualEnv()
. I've bumped the minor version since this is technically a breaking change, as these functions previously resulted in an error being thrown when run on Windows.