This repository has been archived by the owner on Aug 29, 2022. It is now read-only.
v1 #1
Open
v1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronwsmith
reviewed
Apr 4, 2020
| @@ -0,0 +1,4 @@ | |||
| module Land | |||
| class ApplicationJob < ActiveJob::Base | |||
| @@ -0,0 +1,10 @@ | |||
| module Land | |||
| class Campaign < ApplicationRecord | |||
|
|
|||
| class EventType < ApplicationRecord | ||
| include TableName | ||
|
|
||
| lookup_by :event_type, cache: 100 |
There was a problem hiding this comment.
Only this one isn't find_or_create. I'm assuming it's intentional, so maybe we need to add how to add event types to the README or somewhere.
| t.create_lookup_table :event_types, small: true | ||
| end | ||
|
|
||
| execute %[CREATE EXTENSION "uuid-ossp";] |
There was a problem hiding this comment.
Let's make sure we can use this with Elastic Beanstalk + RDS without too much fuss
| @@ -0,0 +1,4 @@ | |||
| # desc "Explaining what the task does" | |||
|
|
||
| See README.md before updating this file. | ||
|
|
||
| ## 0.1.0 |
There was a problem hiding this comment.
Version number doesn't match VERSION = '0.1.2' later on -- let's sync up or update here?
| # frozen_string_literal: true | ||
|
|
||
| Rails.application.routes.draw do | ||
| # Add your own routes here, or remove this file if you don't have need for it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.