Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elab bitfields: check size of type <=32bit rather than checking rank #387

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Elab bitfields: check size of type <=32bit rather than checking rank #387

merged 1 commit into from
Apr 19, 2021

Commits on Mar 2, 2021

  1. Elab bitfields: check size of type <=32bit rather than checking rank 

    When desugaring a bitfield, allow any integral type that is 32 bits
or smaller. Previously this was checking the rank of the type rather
than the size.

This rank check caused issues with standard headers that
declare `uint32_t` to be an `unsigned long` rather than an
`unsigned int`. Here, any bitfields declared as `uint32_t` were
failing to compile even though they are still actually 32 bits.
    Amos Robinson committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    0885909 View commit details
    Browse the repository at this point in the history