Protect against overflows in leaq N(src), dst
#407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If N does not fit in signed 32 bits,
leaq
cannot be used andmov; addq
must be used instead.This was already the case for
leaq
instructions produced by the Asmgen pass, but not for someleaq
instructions produced by Asmexpand.Normally, assemblers should fail if the
leaq
offset is not representable, but this is not always the case (see issue #406).Fixes: #406