Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimplExpr: revised handling of nested conditional, ||, && expressions #458

Merged
merged 2 commits into from
Oct 24, 2022
Merged

SimplExpr: revised handling of nested conditional, ||, && expressions #458

merged 2 commits into from
Oct 24, 2022

Commits on Oct 1, 2022

  1. SimplExpr: revised handling of nested conditional, ||, && operators 

    In a `For_set` destination, a temporary can be reused only if it
always used with the same type. Otherwise, typing of Cminor code fails
later in the compilation pipeline.

This commit implements temporary reuse if and only if the typing
constraint is respected.
- For `&&` and `||`, it avoids the possibility of wrong reuse
  (as reported in #453).
- For nested conditional expressions, it improves a bit the generated
  code by reusing the temporary when possible.

Fixes: #453
    @xavierleroy
    xavierleroy committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    634b136 View commit details
    Browse the repository at this point in the history

  2. Add test for nested conditional, &&, || expressions

    @xavierleroy
    xavierleroy committed Oct 1, 2022
    Configuration menu
    Copy the full SHA
    995f654 View commit details
    Browse the repository at this point in the history