#313 - add code coverage support #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update of scalaTest library versions - new pom file plugin JaCoCo - new pom file profile for "code coverage" measuring - updated readme file
kevinwallimann
approved these changes
Nov 1, 2022
cerveada
reviewed
Nov 1, 2022
| <groupId>org.jacoco</groupId> | ||
| <artifactId>jacoco-maven-plugin</artifactId> | ||
| <version>${jacoco.version}</version> | ||
| </plugin> |
There was a problem hiding this comment.
Do the plugin coordinates need to be declared here? Seem like doing it once in code-coverage profile should be enough.
There was a problem hiding this comment.
You are right. It can be removed from build/plugins section. Tested locally. Current presence is not source of failure. There is planned another related improvement - excludes. I will remove it here. Are you ok with that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#313 - add code coverage support
Closes #313