abris #329 use pull_request_target to fix PRs from forks #334
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it, GitHub considers any fork PR as potentially dangerous. So when using
on pull-request
in action, it will always set all permissions to read.There is
pull_request_target
that is less safe, but it should allowwrite
permission.So I am switching the action to
pull_request_target
and to mitigate the unsafeness I will also switch settings to Require approval for all outside collaborators.There are other solutions to this that may be better, but also more complicated, if you want to look into it @miroslavpojer @Zejnilovic
For more info, see: