Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support upcoming constructor change in Spark 3.5.1-SNAPSHOT #353

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

kevinwallimann
Copy link
Collaborator

Closes #352

Support for the “enableStableIdentifiersForUnionType” option introduced in
apache/spark#41263 was not added. Instead, the option is set to false, which is the default value as documented in https://spark.apache.org/docs/latest/sql-data-sources-avro.html#data-source-option. Users can still use the feature by providing their own SchemaConverter implementation, as explained in https://github.com/absaoss/abris?tab=readme-ov-file#custom-data-conversions
If there is demand to directly support this feature through Abris, it can be implemented, but it would require another reflection-based differentiation among Spark versions that support it or not.

@kevinwallimann kevinwallimann changed the title Use previous versions behaviour as default for new constructor parameter Fix NoSuchMethodException in Spark 3.5.x Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

JaCoCo code coverage report

File Coverage [60.54%]
AbrisAvroDeserializer.scala 60.54%
Total Project Coverage 81.69% 🍏

Copy link
Collaborator

@cerveada cerveada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinwallimann kevinwallimann merged commit 68c24f6 into master Feb 6, 2024
10 of 12 checks passed
@kevinwallimann kevinwallimann deleted the fix/352-nosuchmethod branch February 6, 2024 08:18
@kevinwallimann kevinwallimann changed the title Fix NoSuchMethodException in Spark 3.5.x Support upcoming constructor change in Spark 3.5.1-SNAPSHOT Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix NoSuchMethodException in Spark 3.5.x
2 participants