Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hadoop FS API implementation #43

Closed
dk1844 opened this issue Oct 20, 2020 · 0 comments · Fixed by #44
Closed

Hadoop FS API implementation #43

dk1844 opened this issue Oct 20, 2020 · 0 comments · Fixed by #44
Assignees
@dk1844

Comments

@dk1844
Copy link
Collaborator

dk1844 commented Oct 20, 2020

The reasoning is based on AbsaOSS/enceladus#1556

The implementation should be heavily inspired by https://github.com/AbsaOSS/spark-s3-writer-poc/pull/3
@dk1844 dk1844 self-assigned this Oct 20, 2020
@dk1844 dk1844 mentioned this issue Oct 27, 2020
Merged
@dk1844 dk1844 closed this as completed in #44 Nov 5, 2020
dk1844 added a commit that referenced this issue Nov 5, 2020
@dk1844
Hadoop FS API usage (#44)
d331936 
#43 * Hadoop FS Api for S3 
* fs: FileSystem is now renamed to `inputFs` or `outputFs` to indicate usage.
* protocol is now part of the S3Location (s3/s3n/s3n)
* fileSystem is now only needed for HadoopFs-based storer, SdkS3 storers do not need it.

Migration notes:
 - instead of `myS3String.toS3Location(region1)` use `myS3String.toS3LocationOrFail.withRegion(region1)` or `myS3String.toS3Location.map(_.withRegion).get` (because toS3Location on its own now return an Option)
 - implicit FileSystem is usually needed to signify difference between hdfs and s3 over hadoop fs api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk1844 dk1844

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hadoop FS API usage AbsaOSS/atum
1 participant
@dk1844