Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implicit SparkSessionWrapper is too general of a name #69

Closed
Zejnilovic opened this issue Mar 23, 2021 · 1 comment
Closed

implicit SparkSessionWrapper is too general of a name #69

Zejnilovic opened this issue Mar 23, 2021 · 1 comment

Comments

@Zejnilovic
Copy link
Collaborator

We should rename the wrapper to be more specific.

This solves it for now.

import za.co.absa.spline.harvester.SparkLineageInitializer.{SparkSessionWrapper => SplineSparkSessionWrapper, _}
import za.co.absa.atum.AtumImplicits.{SparkSessionWrapper => AtumSparkSessionWrapper, _}
dk1844 added a commit that referenced this issue Mar 30, 2021
@dk1844
#69 SparkSessionWrapper renamed to AtumSparkSessionWrapper for be…
f7862d3 
…tter interoperability with other SparkSesisonWrappers, e.g. in Spline
@dk1844 dk1844 mentioned this issue Mar 30, 2021
Merged
dk1844 added a commit that referenced this issue Mar 30, 2021
@dk1844
#69 SparkSessionWrapper renamed to AtumSparkSessionWrapper for be…
2e3cde9 
…tter interoperability with other SparkSesisonWrappers, e.g. in Spline (#70)
@dk1844
Copy link
Collaborator

dk1844 commented Apr 7, 2021

Solved in PR #70

@dk1844 dk1844 closed this as completed Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dk1844 @Zejnilovic