Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#88: Add some files to configure the project #89

Merged
merged 7 commits into from
Jul 20, 2021
Merged

#88: Add some files to configure the project #89

merged 7 commits into from
Jul 20, 2021

Conversation

benedeki
Copy link
Collaborator

  • Git configuration
  • Scalastyle support

@benedeki
#88: Add some files configure the project
f78748c 
* Git configuration
* Scalastyle support
@benedeki benedeki self-assigned this Jul 11, 2021
Zejnilovic
Zejnilovic reviewed Jul 13, 2021
View reviewed changes
Copy link
Collaborator

@Zejnilovic Zejnilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add scala style pom.xml entry. Enceladus's entry https://github.com/AbsaOSS/enceladus/blob/develop/pom.xml#L344
and maybe a GitHub action for it?

Otherwise looks good

@benedeki
Copy link
Collaborator Author

benedeki commented Jul 13, 2021 •
edited
Loading

please add scala style pom.xml entry. Enceladus's entry https://github.com/AbsaOSS/enceladus/blob/develop/pom.xml#L344
and maybe a GitHub action for it?

Otherwise looks good

Of course. Silly me to forget pom.xml entry. But what GitHub action you have in mind?

@benedeki
#88: Add some files configure the project
b5f6e5d 
* Added CRLF for Windows *.bat and *.cmd files to .editorconfig
* Scalastyle added to pom.xml files
* Ensured no Scalastyle errors
@Zejnilovic
Copy link
Collaborator

please add scala style pom.xml entry. Enceladus's entry https://github.com/AbsaOSS/enceladus/blob/develop/pom.xml#L344
and maybe a GitHub action for it?
Otherwise looks good

Of course. Silly me to forget pom.xml entry. But what GitHub action you have in mind?

Well, does it run always on Build? Or it needs to be run separately?

@benedeki
Copy link
Collaborator Author

please add scala style pom.xml entry. Enceladus's entry https://github.com/AbsaOSS/enceladus/blob/develop/pom.xml#L344
and maybe a GitHub action for it?
Otherwise looks good

Of course. Silly me to forget pom.xml entry. But what GitHub action you have in mind?

Well, does it run always on Build? Or it needs to be run separately?

Ah, part of build.

@benedeki
#88: Add some files configure the project
e7a42c0 
* Added Spark 3.1 build into the `build-all.sh` script
* Created Windows `build-all.cmd` script
* Upgrade from Spark 3.1.1 to 3.1.2 (fixed several issues of the previous version)
@benedeki
Copy link
Collaborator Author

Oops, it grew a little. I promise I won't add more to it 😄

dk1844
dk1844 previously approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the cross-build for Scala2.12/Spark3.1 and also providing the CMD version of the script

(just read the code)

@benedeki benedeki changed the title #88: Add some files configure the project #88: Add some files to configure the project Jul 14, 2021
@benedeki
Copy link
Collaborator Author

Changed the build-all.sh and `build-all.cmd scripts to stop on fail.
Local build succeeded and this time even the server build, as I see. 🤔

Zejnilovic
Zejnilovic previously approved these changes Jul 19, 2021
View reviewed changes
@benedeki benedeki dismissed stale reviews from Zejnilovic, AdrianOlosutean, and dk1844 via 33c375a July 19, 2021 20:13
Zejnilovic
Zejnilovic reviewed Jul 19, 2021
View reviewed changes
build-all.sh Outdated
@@ -19,7 +19,7 @@
#

set -e

build.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By mistake.

@benedeki benedeki merged commit a1d99db into master Jul 20, 2021
@benedeki benedeki deleted the feature/88-add-some-files-to-configure-the-project branch July 20, 2021 08:26
@benedeki benedeki mentioned this pull request Jul 21, 2021
Merged
Zejnilovic added a commit that referenced this pull request Apr 13, 2022
@Zejnilovic @benedeki
@dk1844 @lokm01
Merge master in release 4.0.0
0360819 
* #88: Add some files to configure the project (#89)
* #88: Add some files configure the project
* Git configuration
* Scalastyle support
* Ensured no Scalastyle errors
* Added CRLF for Windows *.bat and *.cmd files to .editorconfig
* Added Spark 3.1 build into the `build-all.sh` script
* Created Windows `build-all.cmd` script
* Upgrade from Spark 3.1.1 to 3.1.2 (fixes several issues of the previous version)
* `--no-transfer-progress` added to build.yml
* #97 Aggregate control type strategy (#107)
* #97 AggregateControlTypeStrategy suggested API for ControlMeasureBuilder usage
* #97 ControlMeasureBuilder.withAggregateColumn(s) implementations. Todo needs testing, cleanup & documentation update
MeasurementProcessor split into object/class to offer generic processing methods to be reusable.
* #97 ControlMeasureBuilder.withAggregateColumn(s) unit tests added (regression guard)
* #97 ControlMeasureBuilder.withAggregateColumn(s) in README.md, original only-default `cmBuilder.calculateMeasurement` removed
* [maven-release-plugin] prepare release v3.6.0
* [maven-release-plugin] prepare for next development iteration
* #97 readme update - ControlMeasureBuilder API (#110)
* #97 readme update (related to #97, too)
* #97 maven central version badge added
* Feature/113 info permissions config (#114)
* #113 atum info file permissions for hdfs loaded from `atum.hdfs.info.file.permissions` config value
  - tests use MiniDfsCluster to assert controlled correct behavior
  - test update (custom MiniDfsCluster with umask 000 allows max permissions)
  - HdfsFileUtils.DefaultFilePermissions is now publicly exposed; the user is expected to call compose the default and configured value it on his own by e.g.:
`HdfsFileUtils.getInfoFilePermissionsFromConfig().getOrElse(HdfsFileUtils.DefaultFilePermissions)`
* #77 Fix parameter handling bug in CreateInfoFileToolCSV (#78)

* #121 sbt cross comptilation
* #121 multiversion build (scala, spark, json4s).
* #121 hadoop3 used for Spark3/Scala2.12
* #121 sbt github autobuild
* #125 publish, pgp/gpg plugin added; sbt-sonatype howto referenced; model, parent prefixed by `atum-` to conform to the mvn publish, cleanup
* Upgrade dependencies and remove MiniDFSCluster
* GH Action fix
* Remove pom.xml files
* Add licence header and header check
* Fix examples

Co-authored-by: David Benedeki <14905969+benedeki@users.noreply.github.com>
Co-authored-by: Daniel K <dk1844@gmail.com>
Co-authored-by: Jan Scherbaum <kmoj02@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dk1844 dk1844 dk1844 approved these changes

@Zejnilovic Zejnilovic Zejnilovic approved these changes

@AdrianOlosutean AdrianOlosutean AdrianOlosutean left review comments

@AB006J9 AB006J9 Awaiting requested review from AB006J9

@TerezaHrubesova TerezaHrubesova Awaiting requested review from TerezaHrubesova

Assignees

@benedeki benedeki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benedeki @Zejnilovic @dk1844 @AdrianOlosutean