#1863 select list item now shows valueType as additionalText, cleanup

AbsaOSS · Oct 18, 2021 · 377db34 · 377db34
1 parent 61f0715
commit 377db34
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/menas/ui/components/mappingTable/filterEdit/filterTreeEdit.fragment.xml b/menas/ui/components/mappingTable/filterEdit/filterTreeEdit.fragment.xml
@@ -52,8 +52,8 @@
                     <Select selectedKey="{filterEdit>columnName}" items="{path: 'suggestedColumns>/columnNames', templateShareable:false}"
                             forceSelection="false"
                             visible="{= ${filterEdit>_t} === 'EqualsFilter' || ${filterEdit>_t} === 'DiffersFilter' || ${filterEdit>_t} === 'IsNullFilter' }"
-                            valueState="{filterEdit>columnName_valueState}" valueStateText="{filterEdit>columnName_valueStateText}" >
-                        <core:ListItem key="{suggestedColumns>name}" text="{suggestedColumns>name}"/>
+                            valueState="{filterEdit>columnName_valueState}" valueStateText="{filterEdit>columnName_valueStateText}" showSecondaryValues="true">
+                        <core:ListItem key="{suggestedColumns>name}" text="{suggestedColumns>name}" additionalText="{suggestedColumns>type}" />
                     </Select>
                 </t:template>
             </t:Column>

diff --git a/menas/ui/service/EntityDialog.js b/menas/ui/service/EntityDialog.js
@@ -544,8 +544,6 @@ class EditMappingTableDialog extends MappingTableDialog {
       const model = new sap.ui.model.json.JSONModel(jQuery.extend(true, {}, current));
       this.oDialog.setModel(model, "entity");
       this.setFilterEditModel(updatedFilters);
-
-      // todo do for mCR, too.
       this.filterEdit.bindModelToSchemaChange(model);
 
       this.openSimpleOrHdfsBrowsingDialog(this.oDialog, MappingTableDialog.hdfsPropertyNames)